refactored method_siblings #542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aravij
suggested changes
Jul 22, 2020
aravij
previously approved these changes
Jul 22, 2020
| start with the same names | ||
| ''' | ||
| def _is_method_names_close(self, node: ASTNode, new_node: ASTNode) -> bool: | ||
| node_name = re.split('([A-Z][^A-Z]*)', node.name) |
There was a problem hiding this comment.
It is better use [0] right here, it will allow to give better name to node_name. Maybe something like this
Suggested change
| node_name = re.split('([A-Z][^A-Z]*)', node.name) | |
| common_prefix = re.split('([A-Z][^A-Z]*)', node.name)[0] |
And change the next line accordingly.
There was a problem hiding this comment.
unfortunately i cant change it, because, after that I check len(node_name) > 1
There was a problem hiding this comment.
Then we better pick up a different name.
aravij
approved these changes
Jul 22, 2020
|
@rultor merge |
@acheshkov OK, I'll try to merge now. You can check the progress of the merge here |
@acheshkov Done! FYI, the full log is here (took me 18min) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case of #528