Skeleton should reflect the exact overloaded called method

[HDouss]

Today, the skeleton reflects method calls by their name. For example, the skeleton for OverloadMethods.java have:

               <method abstract="false"
                       bridge="false"
                       ctor="false"
                       desc="(Ljava/lang/String;)D"
                       name="methodOne"
                       static="false"
                       visibility="public">
                  <args>
                     <arg type="Ljava/lang/String">?</arg>
                  </args>
                  <return>D</return>
                  <ops>
                     <op code="get">num</op>
                     <op code="put">num</op>
                     <op code="call">OverloadMethods.methodOne</op>
                  </ops>
               </method>
               <method abstract="false"
                       bridge="false"
                       ctor="false"
                       desc="(Ljava/lang/String;Ljava/lang/String;)D"
                       name="methodOne"
                       static="false"
                       visibility="public">
                  <args>
                     <arg type="Ljava/lang/String">?</arg>
                     <arg type="Ljava/lang/String">?</arg>
                  </args>
                  <return>D</return>
                  <ops>
                     <op code="get">num</op>
                     <op code="put">num</op>
                     <op code="call">OverloadMethods.methodOne</op>
                  </ops>
               </method>

The two calls are reported in <op code="call"> elements are OverloadMethods.methodOne and no information is given on which overloaded method is called. This is specially important to calculate LCOM4.

[0crat]

@paulodamaso/z please, pay attention to this issue

[paulodamaso]

@HDouss You are proposing that we should add this information to skeleton?

[HDouss]

@paulodamaso yes this information is clearly lacking. See the example in the ticket description. Looking to the skeleton, we don't know which method is called, we just know that its name is methodOne, but there are 4 methodOnes in the class.

[paulodamaso]

@HDouss Okay, thanks for the clarification

[paulodamaso]

@0crat in

[0crat]

The job #403 assigned to @dgarus/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

[0crat]

@dgarus/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

[dgarus]

@HDouss @paulodamaso

@HDouss You are proposing that we should add this information to skeleton?

I've read the issue and links double and didn`t find what is this information.
Should I propose a new structure of tag or that structure already exists?

[dgarus]

@0crat wait

[HDouss]

@dgarus When analyzing a class and calculating its metric, jpeek starts by building a skeleton. The skeleton is an XML representation of the class, its method, its attributes, and the instructions in each method. For now, the skeleton produced contains the method calls instructions. These method calls instructions contains only the name of the called method. This is not enough to know which method is actually called, because many methods could have the same name.

[dgarus]

@HDouss I got it but I asked

we should add this information to skeleton

"This information" is already described or I should propose a new structure to describe this information?

[HDouss]

@HDouss I got it but I asked

we should add this information to skeleton

"This information" is already described or I should propose a new structure to describe this information?

@dgarus It is not described. The most important thing is that it exists. I could suggest this:

<op code="call">OverloadMethods.methodOne(Ljava/lang/String;Ljava/lang/String;)D</op>

or

<op code="call">
    <name>OverloadMethods.methodOne</name>
    <signature>(Ljava/lang/String;Ljava/lang/String;)D</signature>
</op>

[dgarus]

@HDouss Ok, I got it. Thx!
I like your second variant.
I thought about this way

<op code="call">
    <name>OverloadMethods.methodOne</name>
    <args>
    	<arg type="Ljava/lang/String">?</arg>
    	<arg type="Ljava/lang/String">?</arg>
    </args>
</op>

It seems more formal. WDYT?

[HDouss]

@dgarus agree. Note that this will have a rather big impact on the current metrics calculations. @paulodamaso What do you think?

[paulodamaso]

@HDouss I think that it would be a good idea. Which metrics will be affected by this change?

[HDouss]

@paulodamaso it isn't the metrics, but the way to calculate them. Nearly every xsl file should be modified to adapt its xpath that selects called methods.

[0pdd]

@HDouss the puzzle #437 is still not solved.

[dgarus]

@HDouss could you please close the issue?

[HDouss]

@dgarus Thanks

[0crat]

@sereshqua/z please review this job completed by @dgarus/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed

[sereshqua]

@0crat quality good

[0pdd]

@HDouss 2 puzzles #469, #470 are still not solved; solved: #437.

[0pdd]

@HDouss the puzzle #469 is still not solved; solved: #437, #470.