#112 LORM explained in more detail, implementation method suggested #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Job #155 is now in scope, role is |
Codecov Report
@@ Coverage Diff @@
## master #155 +/- ##
============================================
- Coverage 74.39% 74.36% -0.03%
+ Complexity 128 127 -1
============================================
Files 27 27
Lines 906 905 -1
Branches 54 54
============================================
- Hits 674 673 -1
Misses 210 210
Partials 22 22
Continue to review full report at Codecov.
|
|
@yegor256 The original puzzle here was quite vague and it claimed it was waiting for #110 -- 110 was closed because nobody seemed to understand what should be implemented. The author of this PR did a little reasearch, came to Natural Language Processing and simply left another, more detailed puzzle. Can we count this as a good solution of the ticket which was basically a research task? |
yegor256
reviewed
Feb 7, 2018
| which means that additional input must inserted into the LORM method - that is, a set of | ||
| possible concepts - which are then recognized in a particular method/piece of code. This set | ||
| of possible concepts depends on the `domain` that the class is in. | ||
|
|
There was a problem hiding this comment.
@rok-povsic remove this empty line, since it will cause problems with PDD -- the puzzle won't include the text below the empty line. The same for the next empty line below.
|
@rok-povsic see above |
|
@yegor256 Done. |
|
@rultor merge |
|
@amihaiemil yes, that's exactly how PDD should work. The research was obviously done and it moved us a bit forward in solving this problem. We should merge it and let someone else to make the next step forward, later. |
@rok-povsic @yegor256 Oops, I failed. You can see the full log here (spent 12min) |
|
@rultor try to merge again |
|
Order was successfully finished: +15 points just awarded to @amihaiemil/z, total is +405 |
|
The job #155 is now out of scope |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #112.