#413 support overloading in graph construction #439
Conversation
|
This pull request #439 is assigned to @Vatavuk/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @paulodamaso/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be a monetary reward for this job |
| caller.connections().add(callee); | ||
| callee.connections().add(caller); | ||
| } | ||
| } | ||
| } | ||
| return new ListOf<>(byxml.values()); | ||
| } | ||
|
|
||
| /** | ||
| * Serialize method call to a string. |
There was a problem hiding this comment.
@HDouss I think that these two private methods could be extracted into two new classes
There was a problem hiding this comment.
@paulodamaso I left a new puzzle for that.
|
@paulodamaso ping |
|
@HDouss Thanks you! |
|
@rultor merge |
@paulodamaso OK, I'll try to merge now. You can check the progress of the merge here |
@paulodamaso Done! FYI, the full log is here (took me 19min) |
|
Job was finished in 28 hours, bonus for fast delivery is possible (see §36) |
|
@sereshqua/z please review this job completed by @Vatavuk/z, as in §30; the job will be fully closed and all payments will be made when the quality review is completed |
|
@0crat quality bad |
|
Quality is low, no payment, see §31 |
Resolving issue #413
Add a puzzle to reenable tests after #437 is resolved.