Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many tests are ignored or broken #98

Closed
SilasReinagel opened this issue May 2, 2018 · 14 comments
Closed

Many tests are ignored or broken #98

SilasReinagel opened this issue May 2, 2018 · 14 comments
Labels
bug

Comments

@SilasReinagel
Copy link

I was trying to begin development on Pdd features, and the tests are in a very bad state of disrepair. Many are ignored or fail:

test_pdd.rb
Failed - test_basic
Not Detected - test_rules_failure
Ignored (Windows) - test_git_repo

test_sources.rb
Failed - test_fails_with_verbose_output
Ignored (Windows) - test_ignores_binary_files
Not Detected - test_detects_all_text_files
Not Detected - test_detects_xml_file
Not Detected - test_excludes_by_pattern

test_source.rb
Ignored - test_parsing
Ignored - test_failing_on_invalid_puzzle
Not Detected - test_failing_on_incomplete_puzzle
Ignored (Windows) - test_failing_on_broken_unicode
Ignored - test_failing_on_invalid_puzzle_without_hash_sign
Not Detected - test_failing_on_puzzle_without_leading_space
Not Detected - test_failing_on_puzzle_with_space_after_dash
Ignored (Windows) - test_reads_git_author
Ignored (Windows) - test_skips_invalid_git_mail

These tests should be fixed.
@0crat
Copy link
Collaborator

0crat commented May 2, 2018

@yegor256/z please, pay attention to this issue

@yegor256 yegor256 added the bug label May 3, 2018
@0crat 0crat added the scope label May 3, 2018
@0crat
Copy link
Collaborator

0crat commented May 3, 2018

Job #98 is now in scope, role is DEV

@0crat
Copy link
Collaborator

0crat commented May 3, 2018

Bug was reported, see §29: +15 point(s) just awarded to @SilasReinagel/z

@0crat
Copy link
Collaborator

0crat commented Jun 4, 2018

The job #98 assigned to @pbenety/z, here is why; the budget is 30 minutes, see §4; please, read §8 and §9; if the task is not clear, read this and this; there will be a monetary reward for this job

@0crat
Copy link
Collaborator

0crat commented Jun 9, 2018

@pbenety/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please.

pbenety added a commit to pbenety/pdd that referenced this issue Jun 13, 2018
@pbenety
(cqfn#98) Fix broken tests
0e25181
@pbenety pbenety mentioned this issue Jun 13, 2018
Merged
@pbenety
Copy link
Contributor

pbenety commented Jun 13, 2018

@0crat waiting for review #101

@0crat
Copy link
Collaborator

0crat commented Jun 13, 2018

@0crat waiting for review #101 (here)

@pbenety The impediment for #98 was registered successfully by @pbenety/z

@0pdd 0pdd mentioned this issue Jun 18, 2018
Open
@0pdd
Copy link
Collaborator

0pdd commented Jun 18, 2018

@SilasReinagel the puzzle #102 is still not solved.

@pbenety
Copy link
Contributor

pbenety commented Jun 30, 2018

@SilasReinagel please close this issue. The PR #101 that fix some tests was merged and the puzzle #102 was added to fix the ignored tests in Windows.

@SilasReinagel
Copy link
Author

@pbenety Tests are still broken on Windows. You'll need to open at leas tone more ticket, or fixed the offending non-ignored test.

# Running:

..The system cannot find the path specified.
The system cannot find the path specified.
....S...S.S...F

Failure:
TestSources#test_fails_with_verbose_output [D:/srcctrl/pdd-master/test/test_sources.rb:98]:
84ls2/z1.txt; puzzle at line #1; @todo found, but puzzle can't be parsed, most probably because @todo is not followed by a puzzle marker, as this page explains: https://github.com/yegor256/pdd#how-to-format


bin/rails test D:/srcctrl/pdd-master/test/test_sources.rb:92

..The system cannot find the path specified.
ERROR: Puzzle jx2n6/a.txt:1-1 has an estimate of 0 minutes, which is lower than 30 minutes
.SThe system cannot find the path specified.
E

Error:
TestPDD#test_basic:
RuntimeError: doesn't match '/puzzles/puzzle[file="a.txt"]': <?xml version="1.0"?>
<?xml-stylesheet type='text/xsl' href='http://pdd-xsl.teamed.io/1.0.snapshot.xsl'?>
<puzzles xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="http://pdd-xsd.teamed.io/1.0.snapshot.xsd" version="1.0.snapshot" date="2018-06-30T17:00:06Z">
  <puzzle>
    <ticket>55</ticket>
    <estimate>0</estimate>
    <role>DEV</role>
    <id>55-5a8dd3ad</id>
    <lines>1-1</lines>
    <body>hello!</body>
    <file>lyx3j/a.txt</file>
  </puzzle>
</puzzles>

    D:/srcctrl/pdd-master/test/test_pdd.rb:106:in `block in matches'
    D:/srcctrl/pdd-master/test/test_pdd.rb:105:in `each'
    D:/srcctrl/pdd-master/test/test_pdd.rb:105:in `matches'
    D:/srcctrl/pdd-master/test/test_pdd.rb:36:in `block in test_basic'
    D:/Languages/Ruby/Ruby23-x64/lib/ruby/2.3.0/tmpdir.rb:89:in `mktmpdir'
    D:/srcctrl/pdd-master/test/test_pdd.rb:33:in `test_basic'


bin/rails test D:/srcctrl/pdd-master/test/test_pdd.rb:32

.....

Finished in 0.295418s, 91.3960 runs/s, 115.0913 assertions/s.
27 runs, 34 assertions, 1 failures, 1 errors, 4 skips

You have skipped tests. Run with --verbose for details.

@pbenety
Copy link
Contributor

pbenety commented Jun 30, 2018

@SilasReinagel In AppVeyor, the build runs on Windows and there is no broken tests.

@SilasReinagel
Copy link
Author

@pbenety Okay. There is still something broken. I can open a new bug later. At least this is some progress on making the build work.

@0crat 0crat removed the scope label Jun 30, 2018
@0crat
Copy link
Collaborator

0crat commented Jun 30, 2018

Order was finished: +30 point(s) just awarded to @pbenety/z

@0crat
Copy link
Collaborator

0crat commented Jun 30, 2018

The job #98 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@yegor256 @pbenety @SilasReinagel @0crat @0pdd