Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix DateTime initialization and comparison code to deal correctly with half hour and fifteen minute timezones #1259

Merged
merged 19 commits into from
Oct 27, 2023
Merged

Fix DateTime initialization and comparison code to deal correctly with half hour and fifteen minute timezones #1259

merged 19 commits into from
Oct 27, 2023

Conversation

lukedegruchy
Copy link
Contributor

@lukedegruchy lukedegruchy commented Oct 25, 2023 •
edited by JPercival
Loading

  • Maintain a ZoneOffset field in DateTime, whether derived directly from one of the constructors or converted from an OffsetDateTime or BigDecimal value
  • Replace the State-based implementation of getNormalized() and instead based the timestamp conversion on the above ZoneOffset, if it's non-null
  • Ensure that compareToPrecision() takes the left DateTime's ZoneOffset and passes it to the other DateTime's getNormalized() so that comparison is done based on the same timezone
  • Add lots of new tests.

Closes #1222

@lukedegruchy
Add test to run on Newfoundland TZ machine.
d3f8ca3
@lukedegruchy
Copy all 4 tests failing on the Newfoundland laptop into the timezone…
694b0bf 
… CQL file.
@lukedegruchy
Copy all 4 tests failing on the Newfoundland laptop into the timezone…
7581383 
… CQL file.
@lukedegruchy
Change Newfoundland tests to to SoftAssert.
50bca1b
@lukedegruchy
Ensure all tests fail in Newfoundland.
bd84511
@lukedegruchy
Fix wrong test name.
6cd65d6
@lukedegruchy
Successfully set timezone within a unit test and replicated the expec…
7bc82a6 
…ted failures on an EST/EDT workstation.
@lukedegruchy
Parameterized test with different timezones.
682e04e
@lukedegruchy
Bugfix that works on standard timezone workstation.
b715e61
@lukedegruchy
Add parameterized tests for CqlTypesOperatorsTest, which fails on the…
e03fe16 
… Newfoundland workstation due a flaw in the bugfix.
@lukedegruchy
Instantiate ZoneId in DateTime from all constructors. Add getter. Add…
221220d 
… two getNormalized() methods, one of which takes another ZoneId. Pass in the "this" DateTime's zoneId when normalizing the "other" DateTime. Add stub with comments for new DateTimeTest. Lots of TODOs and cleanup needed. Need to test on Newfoundland workstation.
@lukedegruchy
Fix case in test CQL file to fix pipeline failure. Cleanup code in Da…
4ed57ff 
…teTime.
@lukedegruchy
Add tests to new unit test. Leave open the question of how to handle …
40afa1d 
…DST. TODO: 2 param getNormalized().
@lukedegruchy
More tweaks. Try to optimize the performance of DateTime. Still haven…
55a136e 
…'t figured out why Newfoundland in non-DST fails.
@lukedegruchy
Comment out experimental code that may impact performance.
b0389cb
@lukedegruchy
Stop using ZoneId and use ZoneOffset instead. This seems to resolve t…
bac08ff 
…he Newfoundland non DST bug.
@lukedegruchy
Remove all remnants of old ZoneId code. Add more unit tests.
82ad161
@lukedegruchy
Merge branch 'master' into 1222-build-failure-half-hour-timezone-ex-n…
a97967f 
…ewfoundland-canada
@lukedegruchy lukedegruchy changed the title 1222 build failure half hour timezone ex newfoundland canada Fix DateTime initialization and comparison code to deal correctly with half hour and fifteen minute timezones Oct 27, 2023
@lukedegruchy lukedegruchy marked this pull request as ready for review October 27, 2023 17:09
@JPercival JPercival enabled auto-merge (squash) October 27, 2023 21:22
@JPercival JPercival merged commit 2751734 into master Oct 27, 2023
2 checks passed
@JPercival JPercival deleted the 1222-build-failure-half-hour-timezone-ex-newfoundland-canada branch October 27, 2023 22:31
@JPercival JPercival mentioned this pull request Nov 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@barhodes barhodes barhodes approved these changes

@JPercival JPercival JPercival approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Build failure for Java engine for half-hour offset time zones
3 participants
@lukedegruchy @JPercival @barhodes