Skip to content
This repository has been archived by the owner on Dec 21, 2022. It is now read-only.

Error when getting timezone offset when ID is in form of Country/City #55

Closed
c-schuler opened this issue Feb 11, 2018 · 0 comments
Closed

Error when getting timezone offset when ID is in form of Country/City #55

c-schuler opened this issue Feb 11, 2018 · 0 comments
Assignees
@c-schuler

Comments

@c-schuler
Copy link
Contributor

The getTimeZoneOffset() method in BaseTemporal class assumes that the timezone ID will be in the form of (+|-)hh:mm, e.g. +07:00. However, there may be instances when the ID is of the form Country/City, e.g. America/Denver. This invalid assumption may lead to an ArrayIndexOutOfBoundsException with the current logic.
@c-schuler c-schuler self-assigned this Feb 11, 2018
c-schuler pushed a commit that referenced this issue Feb 11, 2018
Added fix for issue #55 - normalizing the timezone format
c821c0f
c-schuler added a commit that referenced this issue Feb 11, 2018
@c-schuler
Merge pull request #56 from DBCG/fix-55-timezone-id
9d81b24 
Added fix for issue #55 - normalizing the timezone format
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@c-schuler c-schuler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@c-schuler