Ts/38561 read teamscale.timestamp from git.properties #462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t properties. Not used fully yet. Some tests added already.
…mp_from_git.properties # Conflicts: # agent/src/test/java/com/teamscale/jacoco/agent/commit_resolution/git_properties/GitPropertiesLocatorTest.java
…filled from git.properties
… git-properties-jar
DreierF
requested changes
May 23, 2024
...a/com/teamscale/jacoco/agent/commit_resolution/git_properties/GitPropertiesLocatorUtils.java
Outdated
Show resolved
Hide resolved
agent/src/main/java/com/teamscale/jacoco/agent/options/AgentOptions.java
Outdated
Show resolved
Hide resolved
agent/src/main/java/com/teamscale/jacoco/agent/options/AgentOptions.java
Outdated
Show resolved
Hide resolved
DreierF
requested changes
May 24, 2024
| @@ -72,7 +72,7 @@ void searchFile(File file, boolean isJarFile) { | |||
| logger.debug( | |||
| "Found inconsistent git.properties file: the git.properties file in {} either does not specify the" + | |||
| " Teamscale project (teamscale.project) property, or does not specify the commit " + | |||
| "(git.commit.id, git.commit.branch + git.commit.time, or teamscale.timestamp) or ." + | |||
| "(git.commit.id, git.commit.branch + git.commit.time, or teamscale.commit.branch + teamscale.commit.time) or ." + | |||
There was a problem hiding this comment.
Should we use the constants from GitPropertiesLocatorUtils to have them defined in one place?
Co-authored-by: Florian Dreier <dreier@cqse.eu>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue TS-38561
Please respect the vote of the Teamscale bot or flag irrelevant findings as tolerated or false positives. If you feel that the Teamscale config needs adjustment, please state so in a comment and discuss this with your reviewer.