-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makefile not portable #10
Comments
@zbeekman Can you verify this fixes this issue? |
This is a rework of PR cr-marcstevens#4 which was split into smaller PRs which where not related to macOS only. This PR waschanged to reflect the changes which were made in the mean time. Compiling on macOS requires following changes to the Makefile: Some checks were introduced to set compiler flags and file extensions required or specific for macOS. Additionally the order of general pattern rules was changed. The sets of patterns to match certain source files for different CPU features are based on suffixes in their filenames. make on Linux seems to pick the most specific rule whereas make shipped with Xcode does pick the first and therefore disregards the remaining rules. This was fixed by rearranging the rules from most specific to most general. This potentially fixes issue cr-marcstevens#10.
The Makefile still seems a bit dodgy. Let me know if I should open a new Issue, but notice these results if I ask Homebrew to do
Note that:
I don't think any of these issues are MacOS -specific. |
Also, |
Can you look at the simplified_c90 branch, I think it fixes a lot and will go to master soon. |
Yes, I've been following it. BTW, it would be great to get a tag, on either branch. At present, the
|
Done another commit to fix install dirs and added header installation. AVX and others have disappeared, because it was still WIP and still needed a runtime selection. |
Progress, but
Trying to work around it with
So the result is installation of libtool wrapper scripts:
Working around that with a
but the result certainly works and tests ok. |
Have you tried libtool-less installation? What are the required edits you've made that also make sense for linux installation? |
I had not. That's a solution that works for a static builds, but it's not really the "right" solution, I don't think. But it does work.
Merely that there be some way to override |
All linux and macosx builds on travisci succeed, can I close this issue? |
For me branch |
Yes, this is fixed for me. Sorry for the slow reply. |
The default make that ships with the latest Xcode or Mac OS Yosemite does not honor the president going to the most specialized suffix rule: as a result the SIMD compile time flags don't get added and clang chokes trying to compile some of the avx356 code because -mavx2 doesn't get passed. See #4 for additional discussion.
The text was updated successfully, but these errors were encountered: