Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing dependencies #10

Closed
aldreth opened this issue Oct 29, 2020 · 2 comments · Fixed by #11
Closed

Missing dependencies #10

aldreth opened this issue Oct 29, 2020 · 2 comments · Fixed by #11

Comments

@aldreth
Copy link
Contributor

aldreth commented Oct 29, 2020

@testing-library dependencies are missing in both templates, type dependencies are also missing in the typescript template.
@aldreth aldreth mentioned this issue Oct 29, 2020
Merged
@jeffposnick
Copy link
Collaborator

The changes have been pushed out in new npm releases. Thanks!

@aldreth
Copy link
Contributor Author

aldreth commented Oct 29, 2020

Thanks for the template!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update template.json to match CRA templates aldreth/pwa
2 participants
@aldreth @jeffposnick