-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to Crab #3
Comments
i had considered this; might not be opposed... |
I agree with this. |
crabc could be the name of our compiler! Edit: typo |
Upon rereading this, I think that may be what @dogue in fact was suggesting with "crabc". Idk if I can claim it as my idea lol |
Make sure to keep this repository alive and add a link to the new crablang/crab repo in the README so the urls people are sharing don't break. |
i renamed the repo. will do the full replace tomorrow when i set up branching for active development. |
+1 Holy Crab! 🔪🦀🔪 |
Having a name that is a new unique word makes searching for relevant info much easier. Not just on the web, but also on filesystems, package managers etc. i.e. The whole reason people needed to use "golang", because the word "go" diluted search results so badly. Obviously "crab" is a rarer word, but the same logic still applies to some degree. |
Yep that is why we are prefixing it with "crablang". So that the repo is "crablang/crab" Edit: typo |
like "crabc", "crabfmt" makes a lot more sense than "crablangfmt". the go formatter isn't "golangfmt" either. |
Yep. I think we can actually close the issue at this point. The rename has occurred 😎 |
so i reset based on current upstream, and i replaced the readme with crablang readme. but there are still instances of crablang that need changed to crab, if anyone wants to do that. website should stay crablang, other things should not. could probably remove and add |
Encode def span for foreign return-position `impl Trait` in trait Fixes #111031, yet another def-span encoding issue :/ Includes a smaller repro than the issue, but I can confirm it ICEs: ``` query stack during panic: #0 [def_span] looking up span for `rpitit::Foo::bar::{opaque#0}` #1 [object_safety_violations] determining object safety of trait `rpitit::Foo` #2 [check_is_object_safe] checking if trait `rpitit::Foo` is object safe #3 [typeck] type-checking `main` #4 [used_trait_imports] finding used_trait_imports `main` #5 [analysis] running analysis passes on this crate ``` Luckily since this only affects nightly, this desn't need to be backported.
Why have the Lang part? Just call it Crab.
The text was updated successfully, but these errors were encountered: