Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Item being added to cart from previous cart when empty #1319

Closed
keyurshah opened this issue Mar 12, 2020 · 2 comments · Fixed by #1325
Closed

Item being added to cart from previous cart when empty #1319

keyurshah opened this issue Mar 12, 2020 · 2 comments · Fixed by #1325

Comments

@keyurshah
Copy link

Description

When the last item from the cart is deleted, the items from a previously unfinished order are added to the cart.

This seems like a bug to the user as they were not expecting that item to be added to the cart at that time.

If we had a better way to control that situation.

At the least, a notifiation alert that we can display to the user, indicating what just happened and why there is an item in the cart now.

Open to other ideas as well in how to manage that.

Thanks!

Steps to reproduce

  1. Add items to cart
  2. Register as a user
  3. Delete cookies
  4. Add items to cart
  5. Login as same user
  6. Delete items from cart
  7. The previous item from the first cart now shows in the current cart without any notification.

Additional info

  • Craft version: 3.4
  • Craft Commerce: 3
@chrisrowe
Copy link

chrisrowe commented Mar 13, 2020

I'm also seeing this

  • Log in
  • Cart is empty
  • Add items
  • Log out
  • Log in
  • Cart is empty
  • Add items
  • Remove items
  • Cart restores from previous login

@nfourtythree
Copy link
Contributor

Hi All

We have pushed up a fix for this that will be included in the next release.

To get this early, change your craftcms/commerce requirement in composer.json to:

"require": {
  "craftcms/commerce": "dev-develop#8ecec2a4c3c2f8f704ddb0985d5e7cb840961331 as 3.0.11",
  "...": "..."
}

Then run composer update.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants