Orders do not show valdation errors

[Anubarak]

Description

Orders won't show validation errors in the CP because you don't grab the Element from route params but fetch them again from the DB thus validation errors won't be rendered. I made a custom field that needs to be filled in a certain way and while my errors are displayed in the fronend, nothing is shown in the CP. Are there any reasons why you don't show validation errors?

Steps to reproduce

1. Create a field
2. Add the field with certain validation rules in the layout to the Order
3. produce an error and see nothing is shown

Steps to solve

Change the line here OrderController::actionEditOrder

from

public function actionEditOrder($orderId): Response

to

public function actionEditOrder($orderId, Order $order = null): Response
{
    $plugin = Plugin::getInstance();

    $variables = [
        'orderId' => $orderId,
        'order' => $order, <-- set the order from route variables
        'orderSettings' => $plugin->getOrderSettings()->getOrderSettingByHandle('order')
    ];

Then you need to fix the following bug as well in OrdersController line 454
Since these lines are never called (because there is no reason there is an error) they can't throw an exception.

if ($variables['order']->getErrors($field->getField()->handle)) {

must be

if ($variables['order']->getErrors($field->handle)) {

[lukeholder]

Fixed for the next release. Thanks!

[Anubarak]

Can you re-open the issue please?
The error is in the latest version of Commerce 2 again https://github.com/craftcms/commerce/blob/master/src/controllers/OrdersController.php#L59

unless I made a mistace in my composer.json but I can't find a branch without the error

[lukeholder]

Thanks, must have been a bad merge a while ago. Fixed again.