-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Combined performance improvements #1543
Conversation
- Move the total paid/refunded/authorized to order model and out of payments service - Transactions cached on order model - Transactions cleared when updateOrderPaid is called on the order. This would/should be done by anyone creating transactions on the order so it gives us the oppotunity to clear the cache - Fixed the order total in a customer’s orders with admin table
- Order now has a `->setCustomer()` - Query for user and user email way made everytime since a new customer was returned everytime - Customers service `getCustomer()` now always returns a customer with ID - Deprecated the `Customers::getCustomerId()`
…ormance-fixes # Conflicts: # src/elements/Order.php
Co-authored-by: Nathaniel Hammond <nathanielhammond@gmail.com>
Just a note to follow along and to express my thanks for working on this so quickly once raised :) Very keen to see it in as a number of regular customers (all logged in users) have encountered real issues with checkout lately. Unfortunately being End of Financial Year I haven't got capacity to pull this in and test it so hopefully you folks can manage but if there is anything I can supply to help, please let me know. |
Combination of both #1537 and #1538 into a single PR/branch to test all performance improvements combined.