Combined performance improvements #1543
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Move the total paid/refunded/authorized to order model and out of payments service - Transactions cached on order model - Transactions cleared when updateOrderPaid is called on the order. This would/should be done by anyone creating transactions on the order so it gives us the oppotunity to clear the cache - Fixed the order total in a customer’s orders with admin table
- Order now has a `->setCustomer()` - Query for user and user email way made everytime since a new customer was returned everytime - Customers service `getCustomer()` now always returns a customer with ID - Deprecated the `Customers::getCustomerId()`
…ormance-fixes # Conflicts: # src/elements/Order.php
Co-authored-by: Nathaniel Hammond <nathanielhammond@gmail.com>
|
Just a note to follow along and to express my thanks for working on this so quickly once raised :) Very keen to see it in as a number of regular customers (all logged in users) have encountered real issues with checkout lately. Unfortunately being End of Financial Year I haven't got capacity to pull this in and test it so hopefully you folks can manage but if there is anything I can supply to help, please let me know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combination of both #1537 and #1538 into a single PR/branch to test all performance improvements combined.