Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix “Categories Relationship Type” behaviour in migration, and make it clearer how the new behaviour works. #1565

Merged
merged 6 commits into from
Jul 14, 2020

Conversation

lukeholder
Copy link
Member

Welcome @mattstein to make it more clear in the field instructions - will then extend this to sales.

@lukeholder
Copy link
Member Author

lukeholder commented Jul 13, 2020

Will fix #1560

@lukeholder
Copy link
Member Author

Also fixed the migration for people upgrading to Commerce 3. They should stay on sourceElement relation type.

@lukeholder lukeholder merged commit 570ceaf into develop Jul 14, 2020
@lukeholder
Copy link
Member Author

@mattstein merged it for this release, but welcome your input still on the option labels.

@lukeholder lukeholder deleted the feature/3.x-categorySource branch July 14, 2020 07:59
@lukeholder lukeholder changed the title Initial work on making it clearer how category relationships work with promotions. Fix “Categories Relationship Type” behaviour in migration, and make it clearer how the new behaviour works. Jul 14, 2020
@mattstein
Copy link
Contributor

Sorry I didn’t respond sooner, @lukeholder!

I did a quick mockup thinking through this, and while it’s probably annoying scope creep I think it’d be most useful to illustrate how the relationship match works:

category-promotion-mockup

This is a challenging thing to conceptualize, so using a radio field puts the options side by side for the user to compare and consider. Simply illustrating the options could potentially make it easier to understand, save some language, and potentially avoid a trip to the (more technical) docs.

I tried to also focus the language from the perspective of the categories, since we’re choosing them here, which could be problematic since I think the wording of the current options is focused on the purchasables. (Note how the illustrations are the inverse of what they describe.)

Happy to chat further or refine, or just run and hide if this is TMI! :)

@mattstein
Copy link
Contributor

Also I’m aware that’s pretty hideous so please consider it an illustration and not design work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants