Add event trigger to deleteAddressById method in the Addresses service. #810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are building a Gateway plugin for Craft Commerce and need a way to remove addresses from the gateway when a customer deletes an address from Commerce. I've added an event trigger to the deleteAddressById method that we can listen for and then run our own gateway code.
I reused the AddressEvent class and only needed to add a call to getAddressById to get the AddressModel of the address that was being deleted. I would be interested in feedback or suggestions for improvement.
Also, I made a simple typo correction in the documentation comment of the other events in the Addresses service class.