Switch the Order element to override Element::tableAttributeHtml().
#832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of `Element::getTableAttributeHtml()`. This fixes an issue where plugins and modules couldn’t add custom index table attributes via the `Element::EVENT_SET_TABLE_ATTRIBUTE_HTML` event. That event gets fired in `Element::getTableAttributeHtml()` and the method in the Order element class wasn’t then falling back to using that in the default part of the switch statement (line 1820). This change is in line with the method used in the Entry element class.
|
Thanks! |
|
Thank you kind sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the Order element to override
Element::tableAttributeHtml()instead ofElement::getTableAttributeHtml()and fixes an issue where plugins and modules couldn’t add custom index table attributes via theElement::EVENT_SET_TABLE_ATTRIBUTE_HTMLevent.That event gets fired in
Element::getTableAttributeHtml()and the method in the Order element class wasn’t then falling back to using that in the default part of the switch statement (line 1820).This change is in line with the method used in the Entry element class.