Improve release workflow #972
Conversation
mucaho
force-pushed
the
fix_releasing
branch
3 times, most recently
from
62ea48e
to
d6e7b4e
Compare
| @@ -1,5 +1,4 @@ | |||
| /crafty.js | |||
| /crafty-min.js | |||
| dist/ | |||
There was a problem hiding this comment.
Don't we need to include this for the files to actually be accessible to bower?
The whole root issue is that (contrary to standard practices) bower requires you to include the release artifacts in the repository If we don't want to do that, the alternative is to have a separate repo for distribution.
There was a problem hiding this comment.
Hmm good point. If we don't ignore the release artifacts, we will have to check every PR so that users don't accidentally commit their release artifacts (because of security reasons). If we do ignore the release artifacts, I believe you can still add them to the commit (by git add dist/crafty.js), but care has to be taken not to forget adding them on release. What do you suggest?
mucaho
force-pushed
the
fix_releasing
branch
from
d6e7b4e
to
48a9c0f
Compare
|
Ok, modified it so that the |
Collection of improvements that will reduce human error when releasing crafty for download, npm and bower. Grunt task 'release' demands a 'crafty_version' command line parameter which will update the version in the relevant files and builds to 'dist' subfolder. Additional meta improvements.
mucaho
force-pushed
the
fix_releasing
branch
from
48a9c0f
to
766ffd3
Compare
|
Merging, as default workflow stays same, and on release we will have updated artifacts in |
Collection of improvements that will reduce human error when releasing
crafty for download, npm and bower.
Grunt task 'release' demands a 'crafty_version' command line parameter
which will update the version in the relevant files.
Additional meta improvements.
Fixes future bower release inconsistencies.