-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for macOS 10.14 #82
Conversation
Thanks. Can you preserve the code style? |
Merged it anyway. Will format it later. |
@@ -62,7 +66,7 @@ function escapeBlob(data) { | |||
|
|||
function unescapeForIOSAndAndroid(rows) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, doesn't it have to unescape as well for macOS?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not 100% sure, so far I haven't found any issues, however it probably also needs to be updated.
do you know what do I have to do to run this function?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I created #84, I will continue testing on my application but seems to be fine for now
i have tested it on an app i am working on . eveyrthing is good until now. |
You can test it with test/app.js. |
Hi! thanks a lot for the adapter, I'm working on a cross platform application using the newly released react-native-macos and rxdb, it seems the old adapter is now abandoned and full of bugs, so I needed support for macos, just adding it to the pod spec, seems to work!