Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for macOS 10.14 #82

Merged
merged 2 commits into from
Jul 1, 2020
Merged

Add support for macOS 10.14 #82

merged 2 commits into from
Jul 1, 2020

Conversation

ospfranco
Copy link
Contributor

Hi! thanks a lot for the adapter, I'm working on a cross platform application using the newly released react-native-macos and rxdb, it seems the old adapter is now abandoned and full of bugs, so I needed support for macos, just adding it to the pod spec, seems to work!

@craftzdog
Copy link
Owner

Thanks. Can you preserve the code style?

@craftzdog craftzdog merged commit cae8985 into craftzdog:master Jul 1, 2020
@craftzdog
Copy link
Owner

Merged it anyway. Will format it later.

@@ -62,7 +66,7 @@ function escapeBlob(data) {

function unescapeForIOSAndAndroid(rows) {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, doesn't it have to unescape as well for macOS?

Copy link
Contributor Author

@ospfranco ospfranco Jul 16, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure, so far I haven't found any issues, however it probably also needs to be updated.

do you know what do I have to do to run this function?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created #84, I will continue testing on my application but seems to be fine for now

@ospfranco ospfranco mentioned this pull request Jul 16, 2020
@mouhsinelonly
Copy link

i have tested it on an app i am working on . eveyrthing is good until now.

@craftzdog
Copy link
Owner

craftzdog commented Jul 22, 2020

You can test it with test/app.js.
The test tries to insert data with '\0' here: https://github.com/craftzdog/react-native-sqlite-2/blob/master/test/app.js#L185
It triggers escaping/unescaping data.
And you should see the result like this if it works as expected:

Screen Shot 2020-07-22 at 11 47 57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants