Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension no longer works due to type error #5

Closed
tambry opened this issue Jun 8, 2018 · 10 comments
Closed

Extension no longer works due to type error #5

tambry opened this issue Jun 8, 2018 · 10 comments
Assignees
Labels
bug Something isn't working

Comments

@tambry
Copy link

tambry commented Jun 8, 2018

Seems to happen on all videos for me.

Uncaught TypeError: Cannot read property 'style' of null
    at testURL (chrome-extension://eillffkhnelgaaladkpjeggognlimgbl/content.js:138)
    at HTMLBodyElement.<anonymous> (chrome-extension://eillffkhnelgaaladkpjeggognlimgbl/content.js:199)

Code causing the error

@craigmhughes
Copy link
Owner

Where were you when you encountered this error?

@tambry
Copy link
Author

tambry commented Jun 8, 2018

@craigmhughes It happens on any video for me. For example, even on this Nyan cat video.

@craigmhughes
Copy link
Owner

Weird, I'm trying every test I can think of to find a break but it doesn't happen for me. I can't believe I'm about to say this but what happened when you refreshed the page, still the same?

@craigmhughes craigmhughes added the bug Something isn't working label Jun 8, 2018
@craigmhughes craigmhughes self-assigned this Jun 8, 2018
@tambry
Copy link
Author

tambry commented Jun 8, 2018

Refreshing the page still results in the same. It even happens in icognito mode after doing a cacheless refresh with CTRL+F5 and TidyTube is the only extension enabled.

But I noticed that when the "Nothing Loading" button is enabled, it results in a similar error (the previously mentioned error still occurs afterwards):

content.js:67 Uncaught TypeError: Cannot read property 'style' of null
    at ttSetup (content.js:67)
    at content.js:33

@craigmhughes
Copy link
Owner

Okay, I'm going to be adding some conditionals that will execute only when those elements can be read. I should've done this in the first place. Hopefully this will resolve your issues. Fingers crossed.

@tambry
Copy link
Author

tambry commented Jun 8, 2018

Worth noting that due to these errors, the "Related" section doesn't get removed and thus still shows up. Silencing the errors probably won't make it work.

Here's the HTML that I receive for the Nyan cat video.

@craigmhughes
Copy link
Owner

What OS are you using?

@tambry
Copy link
Author

tambry commented Jun 8, 2018

I'm on Windows 10 1803 17134.81 64-bit. Physically located in Estonia, connecting to YouTube over IPv6.

1.1.5 indeed hides the errors, but the extension doesn't fulfill its purpose.

@craigmhughes
Copy link
Owner

I think I may have found the issue you're referring to. I've updated again.

@tambry
Copy link
Author

tambry commented Jun 8, 2018

I can confirm it works now. Thanks!

@tambry tambry closed this as completed Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants