-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extension no longer works due to type error #5
Comments
Where were you when you encountered this error? |
@craigmhughes It happens on any video for me. For example, even on this Nyan cat video. |
Weird, I'm trying every test I can think of to find a break but it doesn't happen for me. I can't believe I'm about to say this but what happened when you refreshed the page, still the same? |
Refreshing the page still results in the same. It even happens in icognito mode after doing a cacheless refresh with CTRL+F5 and TidyTube is the only extension enabled. But I noticed that when the "Nothing Loading" button is enabled, it results in a similar error (the previously mentioned error still occurs afterwards):
|
Okay, I'm going to be adding some conditionals that will execute only when those elements can be read. I should've done this in the first place. Hopefully this will resolve your issues. Fingers crossed. |
Worth noting that due to these errors, the "Related" section doesn't get removed and thus still shows up. Silencing the errors probably won't make it work. Here's the HTML that I receive for the Nyan cat video. |
What OS are you using? |
I'm on Windows 10 1803 17134.81 64-bit. Physically located in Estonia, connecting to YouTube over IPv6. 1.1.5 indeed hides the errors, but the extension doesn't fulfill its purpose. |
I think I may have found the issue you're referring to. I've updated again. |
I can confirm it works now. Thanks! |
Seems to happen on all videos for me.
Code causing the error
The text was updated successfully, but these errors were encountered: