Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Common AC api: Better handle protocols with power toggles. #1002

Merged
merged 1 commit into from
Dec 11, 2019
Merged

[Bug] Common AC api: Better handle protocols with power toggles. #1002

merged 1 commit into from
Dec 11, 2019

Conversation

crankyoldgit
Copy link
Owner

  • Add a cleaner way of handling HomeAssistant mode "off" -> power "off"
  • Add more comments to improve the code readablity.
  • Handle A/Cs with power toggles better.
  • Add unit tests to confirm correct operation with Whirlpool A/Cs

Fixes #1001
FYI @spyzp

@crankyoldgit
[Bug] Common AC api: Better handle protocols with power toggles.
ee41fb4 
* Add a cleaner way of handling HomeAssistant mode "off" -> power "off"
* Add more comments to improve the code redablity.
* Handle A/Cs with power toggles better.
* Add unit tests to confirm correct operation with Whirlpool A/Cs

Fixes #1001
FYI @spyzp
@crankyoldgit crankyoldgit self-assigned this Dec 5, 2019
@crankyoldgit crankyoldgit mentioned this pull request Dec 5, 2019
Closed
@crankyoldgit
Copy link
Owner Author

7 days have passed. Merging.

@crankyoldgit crankyoldgit merged commit 5afbf62 into master Dec 11, 2019
@crankyoldgit crankyoldgit deleted the Issue1001 branch December 13, 2019 03:36
crankyoldgit added a commit that referenced this pull request Jan 6, 2020
@crankyoldgit
v2.7.2 release
cdfe2fd 
_v2.7.2 (20200106)_

**[Bug Fixes]**
- Common AC api: Better handle protocols with power toggles. (#1002)

**[Features]**
- Experimental detailed support for LG a/c. (#1008 #1009)

**[Misc]**
- Add remote codes for Aloka LED lamp. (#1005)
- Improve Supported Devices scraping. (#1006)
@crankyoldgit crankyoldgit mentioned this pull request Jan 6, 2020
Merged
crankyoldgit added a commit that referenced this pull request Jan 6, 2020
@crankyoldgit
v2.7.2 release (#1011)
e492ff1 
_v2.7.2 (20200106)_

**[Bug Fixes]**
- Common AC api: Better handle protocols with power toggles. (#1002)

**[Features]**
- Experimental detailed support for LG a/c. (#1008 #1009)

**[Misc]**
- Add remote codes for Aloka LED lamp. (#1005)
- Improve Supported Devices scraping. (#1006)
@ayavilevich ayavilevich mentioned this pull request Sep 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@jamsinclair jamsinclair Awaiting requested review from jamsinclair

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

Assignees

@crankyoldgit crankyoldgit

Labels
bug enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

seems a mistake in IRac.cpp
1 participant
@crankyoldgit