Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve i18n text. #966

Merged
merged 3 commits into from
Oct 15, 2019
Merged

Improve i18n text. #966

merged 3 commits into from
Oct 15, 2019

Conversation

crankyoldgit
Copy link
Owner

  • Fix some issues with French locale text.
  • Fix a typo. (Mold-->Mould)
  • Improve test/Makefile dependencies.

@crankyoldgit crankyoldgit self-assigned this Oct 13, 2019
@karthikbeam
Copy link

Seems mould and mold are both valid? https://en.wikipedia.org/wiki/Mold

@crankyoldgit
Copy link
Owner Author

Seems mould and mold are both valid? https://en.wikipedia.org/wiki/Mold

@karthikbeam
"mold (US) or mould (UK / NZ / AU / ZA / IN / CA / IE)" from the wiki page.

Hence if en-US is chosen, it will present as "Mold" and for the other English (en) it's "Mould".

See: https://github.com/crankyoldgit/IRremoteESP8266/pull/966/files#diff-009b75363e4ce0c75fa66b48f72aa2ed

@karthikbeam
Copy link

Ah right sure! and AU is considered native Locale, so Mould is a better fit 👍

@crankyoldgit crankyoldgit merged commit 51de265 into master Oct 15, 2019
@crankyoldgit crankyoldgit deleted the fix_fr branch October 16, 2019 08:47
@crankyoldgit crankyoldgit added the Hacktoberfest Hacktoberfest participation label Oct 20, 2019
crankyoldgit added a commit that referenced this pull request Oct 30, 2019
@crankyoldgit
v2.7.0 Release
537aa30 
_v2.7.0 (20191030)_

**[Bug Fixes]**
- auto_analyse: Fix > 64 bit send code generation. (#976)
- auto_analyse: Fix missing arguments in generated code for send64+ (#972)
- IRsendProntoDemo: Fix compile issue on ESP32 platform. (#938)
- IRMQTTServer: Fix compile error when `MQTT_ENABLE` is false. (#933)

**[Features]**
- Add Hitachi 424 bit A/C support. (#975, #980, #981)
- Experimental detailed support for `DAIKIN152` (#971)
- Mitsubishi 112bit A/C support (#947, #968)
- gc_decode: Adding Support for Decoding codes in raw code format (#963)
- Refactor to use common routines/macros to handle bit manipulation. (#934)
- Use centralised common strings. Saves ~1.5k of program space. (#946)
- Add Internationalisation (i18n) / Locale support. (#946, #955, #966)
  - `de-CH`: Swiss German. (#949, #954)
  - `de-DE`: German. (#946, #950, #952)
  - `en-AU`: English/Australian (Default locale) (#946)
  - `en-IE`: English/Irish (#946)
  - `en-UK`: English/United Kingdom (#946)
  - `en-US`: English/United States (#946)
  - `es-ES`: Spanish. (#953)
  - `fr-FR`: French. (#962)
- Port CI pipeline to PlatformIO (#936)

**[Misc]**
- Add DAIKIN128 & DAIKIN152 to `decodeToState()` (#982)
- auto_analyse: Produce better code when leader is detected. (#977)
- Coolix A/C improvements (#944)
- A/C setRaw/getRaw/stateReset() cleanup. (#967)
- Add documentation on how to use & support the i18n aspects of the library.
- Make travis checks faster. (#957)
- Translate README.md to french (#959)
- Fixed Coolix kCoolixDefaultState (#941)
- Improve generation of list of pio projects. (#940)
@crankyoldgit crankyoldgit mentioned this pull request Oct 30, 2019
Merged
crankyoldgit added a commit that referenced this pull request Oct 30, 2019
@crankyoldgit
v2.7.0 Release (#983)
f9d7e5c 
_v2.7.0 (20191030)_

**[Bug Fixes]**
- auto_analyse: Fix > 64 bit send code generation. (#976)
- auto_analyse: Fix missing arguments in generated code for send64+ (#972)
- IRsendProntoDemo: Fix compile issue on ESP32 platform. (#938)
- IRMQTTServer: Fix compile error when `MQTT_ENABLE` is false. (#933)

**[Features]**
- Add Hitachi 424 bit A/C support. (#975, #980, #981)
- Experimental detailed support for `DAIKIN152` (#971)
- Mitsubishi 112bit A/C support (#947, #968)
- gc_decode: Adding Support for Decoding codes in raw code format (#963)
- Refactor to use common routines/macros to handle bit manipulation. (#934)
- Use centralised common strings. Saves ~1.5k of program space. (#946)
- Add Internationalisation (i18n) / Locale support. (#946, #955, #966)
  - `de-CH`: Swiss German. (#949, #954)
  - `de-DE`: German. (#946, #950, #952)
  - `en-AU`: English/Australia (Default locale) (#946)
  - `en-IE`: English/Ireland (#946)
  - `en-UK`: English/United Kingdom (#946)
  - `en-US`: English/United States (#946)
  - `es-ES`: Spanish. (#953)
  - `fr-FR`: French. (#962)
- Port CI pipeline to PlatformIO (#936)

**[Misc]**
- Add DAIKIN128 & DAIKIN152 to `decodeToState()` (#982)
- auto_analyse: Produce better code when leader is detected. (#977)
- Coolix A/C improvements (#944)
- A/C setRaw/getRaw/stateReset() cleanup. (#967)
- Add documentation on how to use & support the i18n aspects of the library.
- Make travis checks faster. (#957)
- Translate README.md to french (#959)
- Fixed Coolix kCoolixDefaultState (#941)
- Improve generation of list of pio projects. (#940)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sillyfrog sillyfrog Awaiting requested review from sillyfrog

@darshkpatel darshkpatel Awaiting requested review from darshkpatel

@markszabo markszabo Awaiting requested review from markszabo

Assignees

@crankyoldgit crankyoldgit

Labels
enhancement Hacktoberfest Hacktoberfest participation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@crankyoldgit @karthikbeam