Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove c4autoconf #331

Merged
merged 1 commit into from
Jun 19, 2024
Merged

refactor: remove c4autoconf #331

merged 1 commit into from
Jun 19, 2024

Conversation

ee7
Copy link
Contributor

@ee7 ee7 commented Jun 11, 2024

Issue

#214

Description

Continue (from #235, #236, #237, #329, and #330) to prepare for the new con4m, by no longer running the con4m
executable at build time to generate c4autoconf.nim. This was a module that:

  • Unloaded attributes into Nim-native data structures.

  • Generated Nim-native procs to access that data.

We want to access attributes more directly from the con4m state, which also ensures that attribute access can be multi-threaded. Furthermore, syncing the con4m attribute state with the Nim-native data structures was previously a significant source of complexity.

As of the previous commit (9df364b, "refactor: remove remaining uses of ChalkConfig"), there was already no remaining usage of autogenerated types or procs.

Closes: #214


With this PR:

$ git log -1 --format='%h %s'
b45dafd refactor: remove c4autoconf
$ git grep --ignore-case 'autoconf' | wc -l
0

@ee7 ee7 marked this pull request as ready for review June 11, 2024 21:45
@ee7 ee7 requested a review from viega as a code owner June 11, 2024 21:45
@ee7 ee7 requested a review from miki725 June 11, 2024 21:45
@ee7 ee7 mentioned this pull request Jun 13, 2024
4 tasks
@ee7 ee7 force-pushed the ee7/avoid-c4autoconf-part5 branch from 9c11a8a to de237f0 Compare June 17, 2024 19:16
@ee7 ee7 force-pushed the ee7/avoid-c4autoconf-part6 branch from 2ab5b80 to 9c54d7b Compare June 17, 2024 19:20
Base automatically changed from ee7/avoid-c4autoconf-part5 to main June 18, 2024 18:58
@ee7 ee7 force-pushed the ee7/avoid-c4autoconf-part6 branch from 9c54d7b to b45dafd Compare June 18, 2024 18:58
@ee7 ee7 merged commit 9c4fc0b into main Jun 19, 2024
4 checks passed
@ee7 ee7 deleted the ee7/avoid-c4autoconf-part6 branch June 19, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

con4m v2 prep: stop using autogenerated con4m API
2 participants