Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enable tests in ci #34

Closed
indecisivedragon opened this issue Jun 17, 2024 · 2 comments · Fixed by #38
Closed

enable tests in ci #34

indecisivedragon opened this issue Jun 17, 2024 · 2 comments · Fixed by #38
Assignees
@ee7
Labels
testing testing-related tasks

Comments

@indecisivedragon
Copy link
Contributor

No description provided.

@indecisivedragon indecisivedragon added the testing testing-related tasks label Jun 17, 2024
@ee7
Copy link
Contributor

ee7 commented Jun 17, 2024 •
edited
Loading

The tests aren't in a place to enable in CI yet. For example, we don't have a command for which an exit status of 0 implies that the tests pass.

@ee7 ee7 mentioned this issue Jun 18, 2024
Merged
2 tasks
@ee7
Copy link
Contributor

ee7 commented Jun 19, 2024

The tests aren't in a place to enable in CI yet.

I wrote that, but after #37 I think this is already well worth doing, even if the workflow indicating success does not currently imply that the tests pass.

I created #38 as something to iterate on. Let's say that, if merged, that PR can close this ticket; we can open follow-up tickets for further improvements.

ee7 added a commit that referenced this issue Jun 27, 2024
@ee7
.github: add initial workflow to run tests (#38)
14604ad 
Add an initial workflow to build the code and run the tests in CI on
x86_64 Linux and aarch64 macOS.

Also, switch to the latest stable GCC release (GCC 14.1, 2024-05-07) in
the Linux job to help make newer compiler warnings more visible.

Closes: #34
@ee7 ee7 closed this as completed in #38 Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ee7 ee7

Labels
testing testing-related tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

.github: add initial workflow to run tests crashappsec/libcon4m
2 participants
@indecisivedragon @ee7