Allow writing changes in the github action #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
|
@epage Hi! I'm curious to hear what your thoughts are about this? |
|
Sorry for the delay in getting back on this. We have mostly focused talk on Sarif support (#594) though providing suggested edits is an interesting idea (though that linked Action seems to be abandoned) |
epage
reviewed
Feb 6, 2023
|
Interesting, I didn't know about Sarif! Actions like the one I've combined this one with could probably read from sarif outputs in the future, and then emit code suggestions based on that. For now, the current solution has been working great for us, for the past week. I've now added documentation; can you take another look, please? Thanks! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! I think it'd make sense to allow writing changes in the github action itself, so that this can be combined with other actions like https://github.com/getsentry/action-git-diff-suggestions. That way, I can run
typosin my repository, and instead of a hard failure, it will suggest code changes to fix the typos.See bnjbvr/octotest#5 for an example.
(The entrypoint file will run the command twice, so I suspect that it will only have an effect the first time. I can tweak the script so it doesn't, but as far as I could tell, this didn't add extra warnings or other issues, so that seemed ok to me. Let me know if you'd like me to fix that!)