Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix and improve read command #236

Merged
merged 1 commit into from
Oct 23, 2017
Merged

Fix and improve read command #236

merged 1 commit into from
Oct 23, 2017

Conversation

mfussenegger
Copy link
Member

No description provided.

@mfussenegger mfussenegger force-pushed the j/read-command branch 2 times, most recently from 11b705e to cf824da Compare October 19, 2017 19:43
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 83.131% when pulling cf824da on j/read-command into 1ae1c7b on master.

4 similar comments
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 83.131% when pulling cf824da on j/read-command into 1ae1c7b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 83.131% when pulling cf824da on j/read-command into 1ae1c7b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 83.131% when pulling cf824da on j/read-command into 1ae1c7b on master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.7%) to 83.131% when pulling cf824da on j/read-command into 1ae1c7b on master.

@coveralls
Copy link

coveralls commented Oct 19, 2017

Coverage Status

Coverage increased (+0.1%) to 84.02% when pulling cc47be8 on j/read-command into 1ae1c7b on master.

1 similar comment
@coveralls
Copy link

coveralls commented Oct 19, 2017

Coverage Status

Coverage increased (+0.1%) to 84.02% when pulling cc47be8 on j/read-command into 1ae1c7b on master.

@codecov-io
Copy link

codecov-io commented Oct 19, 2017

Codecov Report

Merging #236 into master will increase coverage by 0.14%.
The diff coverage is 94.87%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #236      +/-   ##
==========================================
+ Coverage   83.87%   84.01%   +0.14%     
==========================================
  Files          19       19              
  Lines        2208     2234      +26     
==========================================
+ Hits         1852     1877      +25     
- Misses        356      357       +1
Impacted Files Coverage Δ
src/crate/crash/test_commands.py 100% <100%> (ø) ⬆️
src/crate/crash/commands.py 90.17% <88.23%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ae1c7b...2c7d750. Read the comment docs.

Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good.
it's up to you whether you want to add a changelog entry. it's not necessary, but you could also "sell" it as an improvement

@coveralls
Copy link

coveralls commented Oct 23, 2017

Coverage Status

Coverage increased (+0.1%) to 84.02% when pulling 2c7d750 on j/read-command into 1ae1c7b on master.

@mfussenegger mfussenegger merged commit 2c7d750 into master Oct 23, 2017
@mfussenegger mfussenegger deleted the j/read-command branch October 23, 2017 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants