Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve bundling of custom JavaScript and CSS assets #255

Merged
merged 6 commits into from
Apr 19, 2021

Conversation

amotl
Copy link
Member

@amotl amotl commented Apr 14, 2021

Hi there,

this patch removes assets which have been inlined into this repository before and replaces them by a bundling system based on yarn and webpack. It will resolve #241.

With kind regards,
Andreas.

@amotl amotl requested review from msbt and nomicode April 14, 2021 17:45
@amotl amotl marked this pull request as ready for review April 14, 2021 17:45
@amotl amotl requested a review from a team April 14, 2021 17:45
@amotl amotl linked an issue Apr 14, 2021 that may be closed by this pull request
@nomicode
Copy link
Contributor

will let @msbt review this one :)

@msbt
Copy link
Collaborator

msbt commented Apr 15, 2021

I've tried that build and it works fine! All I had to do was

sudo apt update
curl -sL https://deb.nodesource.com/setup_14.x | sudo bash -
sudo apt-get install -y nodejs
sudo npm install --global yarn

beforehand, then it ran through as expected, nice work @amotl!

Base automatically changed from amo/remove-unused to master April 19, 2021 11:25
@amotl
Copy link
Member Author

amotl commented Apr 19, 2021

I've tried that build and it works fine! All I had to do was [install Node.js and yarn].

Thank you. I've added respective instructions through 8d9af3a.

@amotl
Copy link
Member Author

amotl commented Apr 19, 2021

I also removed Fontawesome completely through 4b37ec0.

Copy link
Collaborator

@msbt msbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looking good!

@amotl amotl merged commit 26a25ef into master Apr 19, 2021
@amotl amotl deleted the amo/overhaul-js-css branch April 19, 2021 12:35
@amotl amotl mentioned this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CSS minification should be handled by the build system
3 participants