Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0-based parameter binding not supported #63

Closed
l7s opened this issue Jul 12, 2017 · 4 comments
Closed

0-based parameter binding not supported #63

l7s opened this issue Jul 12, 2017 · 4 comments
Labels

Comments

@l7s
Copy link

l7s commented Jul 12, 2017

Hi, line below:

https://github.com/crate/crate-pdo/blob/0.6.2/src/Crate/PDO/PDOStatement.php#L200

needs to be changed to:

$zero_based = array_key_exists(0, $input_parameters_array);

or when sending a query with first value being NULL an exception will be thrown.

Regards,
Chris

@chaudum
Copy link
Contributor

chaudum commented Jul 12, 2017

hi @l7s
thanks for reporting. you're right, the isset() check is not NULL safe.
do you want to provide a fix? otherwise we'll take care of if.

@chaudum chaudum added the bug label Jul 12, 2017
@l7s
Copy link
Author

l7s commented Jul 12, 2017

Hi, if could you please take care of it that would be great.
Regards,
Chris

@Taliik
Copy link
Member

Taliik commented Jul 17, 2017

hey @l7s
this issue was fixed with #65 and it is released in version 0.6.3

@l7s
Copy link
Author

l7s commented Jul 17, 2017

Great, closing this issue.

@l7s l7s closed this as completed Jul 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants