Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added automatic conversion of UUIDs to strings. #567

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

SStorm
Copy link
Contributor

@SStorm SStorm commented Jul 27, 2023

About

When transport-encoding SQL parameters to JSON, Python's UUID type has not been taken into consideration. This patch intends to improve the situation.

@SStorm SStorm marked this pull request as ready for review July 27, 2023 14:36
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much. Just added a few suggestions.

CHANGES.txt Outdated Show resolved Hide resolved
src/crate/client/http.py Outdated Show resolved Hide resolved
Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you again for addressing my suggestions. LGTM, but I also added @matriv to receive a second perspective.

Copy link
Contributor

@matriv matriv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx! left just a question out of my curiosity.

src/crate/client/test_http.py Show resolved Hide resolved
@SStorm SStorm merged commit fac7355 into master Jul 28, 2023
29 checks passed
@SStorm SStorm deleted the r/add-uuid-serializer branch July 28, 2023 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants