reduce deprecation notices #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on warnings while running tests see symfony/symfony#16276
craue
force-pushed
the
2.1.x-reduce-deprecation-notices
branch
from
29d8741
to
1805f03
Compare
|
@stof, could you give me some hints on those two? |
craue
force-pushed
the
2.1.x-reduce-deprecation-notices
branch
from
1805f03
to
d08d311
Compare
|
Alright, the missing |
| </service> | ||
|
|
||
| <service id="craue.form.flow.step_field_extension" class="Craue\FormFlowBundle\Form\Extension\FormFlowStepFieldExtension"> | ||
| <tag name="form.type_extension" extended_type="Symfony\Component\Form\Extension\Core\Type\HiddenType" /> |
There was a problem hiding this comment.
we use dashes, not underscores in XML in tag attribute names
…es due to the "empty_value" option
craue
force-pushed
the
2.1.x-reduce-deprecation-notices
branch
from
d08d311
to
c138859
Compare
| xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
|
|
||
| <services> | ||
| <service id="twig.extension.craue_integration_test" class="Craue\FormFlowBundle\Tests\IntegrationTestBundle\Twig\Extension\IntegrationTestTwigExtension"> |
craue
force-pushed
the
2.1.x-reduce-deprecation-notices
branch
from
c138859
to
3fc3576
Compare
|
Thank you for your feedback, @stof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least with Symfony 2.7, I could get rid of all deprecation notices.
With 2.8, this won't be possible due to scopes. But there are two other notices I'm unable to track down yet (Travis log):
choices_as_valuesisn't used in the code at all.ArrayKeyChoiceListisn't used in the code at all.