Add threat level indicators for monsters in offline tiles

[GnarledBeach]

Webtiles and console both have a monster list at the bottom-right of
the screen which lists all monsters in view color-coded by rough
threat level. Many players have expressed a desire for something
similar in offline tiles, to provide always-visible indicators of the
threat levels of all enemies in view. This commit adds translucent
colored backgrounds -- dark grey, light grey, yellow, and red --
to indicate trivial, easy, tough, and nasty monsters respectively.

Additionally, these indicators are configurable with a new option in
the options file, "tile_show_threat_levels". Each type of indicator
can be independently enabled or disabled by including or omitting it
in the option file line. For example, the following...

"tile_show_threat_levels = tough nasty"

...will show only yellow (tough) and red (nasty) threat indicators.

I have experimented with various styles of indicators, as shown in the
following thread:

https://crawl.develz.org/tavern/viewtopic.php?f=8&t=26439

I am open to changing back to a different style, or even making
multiple styles available and letting the player choose which style to
use, if any. This style is the best in my opinion, as it is very
noticeable while being subtle enough not to interfere with any other
monster or monster-associated graphics. I have playtested this feature
through a 6-rune run with no problems, technical nor cosmetic.

[aidanholm]

Thanks for the PR! Played a few games now with this, works pretty well.

Code looks good; could you please add webtiles support? You'll need to add the same logic in tiledgnbuf.cc to cell_renderer.js; the two are analagous. You'll also need to update enums.js with another call to fg_flags.exclusive_flags.push (I think); then you can just access cell.fg.TRIVIAL etc from cell_renderer.js.

Separately, please squash the five commits into one commit as well, since most of the commits are fixes, not functionality changes.

[aidanholm]

Thanks for the PR; I've moved work on this to the threat-levels branch.

[GnarledBeach]

Hi Aidan, Interesting to hear from you again on this. I've had the older follow-up (requesting consolidation of commits and support added to webtiles) sitting in my inbox since you sent it, trying to decide whether to follow up... You see, despite being a former software developer, I burned out on it and really don't like to do it that much anymore. I was motivated to contribute this feature because I badly wanted it. I didn't think webtiles needed it because it already has the color-coded list at the bottom right, thus already providing an always-visible indicator of apparent danger levels. And I'm not much of a web developer or Javascript guy -- most of my background and passion is in lower-level development, C and C++ being where I am most comfortable. So I have been pretty ambivalent about following up...apologies. Cheers, Caleb

…

On Tue, Nov 26, 2019, 7:39 AM Aidan Holm ***@***.***> wrote: Closed #1120 <#1120>. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1120?email_source=notifications&email_token=ABPBGX4QBSCDCKWLHABBP2DQVUYKLA5CNFSM4IGLBLV2YY3PNVWWK3TUL52HS4DFWZEXG43VMVCXMZLOORHG65DJMZUWGYLUNFXW5KTDN5WW2ZLOORPWSZGOVDHZWMA#event-2832177968>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPBGX5M67R5BAP4OE5RZ5DQVUYKLANCNFSM4IGLBLVQ> .

[aidanholm]

Hey Caleb,

No worries, that happens to all of us sooner or later. Thanks for all of the hard work you've already put into this feature; it should be merged soon!

Cheers,
Aidan

[GnarledBeach]

Awesome, thanks for understanding and cool to hear that it will probably still get merged! Cheers, Caleb

…

On Wed, Nov 27, 2019, 10:07 AM Aidan Holm ***@***.***> wrote: Hey Caleb, No worries, that happens to all of us sooner or later. Thanks for all of the hard work you've already put into this feature; it should be merged soon! Cheers, Aidan — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#1120?email_source=notifications&email_token=ABPBGX2H2PNMZDJU53D67BLQV2SNPA5CNFSM4IGLBLV2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEFKFLZI#issuecomment-559175141>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABPBGX4LMC46GWYTMT2XQUTQV2SNPANCNFSM4IGLBLVQ> .