Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A win is not listed on my scoring page #2

Closed
syranez opened this issue Dec 2, 2019 · 2 comments
Closed

A win is not listed on my scoring page #2

syranez opened this issue Dec 2, 2019 · 2 comments

Comments

@syranez
Copy link

syranez commented Dec 2, 2019

Describe the bug
A win is not listed on my scoring page.

To Reproduce
Steps to reproduce the behavior:

  1. Look at https://underhound.eu/crawl/morgue/syranez/morgue-syranez-20191122-180451.txt
  2. See that it is a GrEE of Vehumet win
  3. Go to http://crawl.akrasiac.org/scoring/players/syranez.html
  4. Look at my wins. See that there is no GrEE / Vehumet game
  5. Scroll down to "Recent Games". See it is not listed at all but games played after that are.

Expected behavior
The game is on my scoring page
@rawlins
Copy link
Member

rawlins commented Dec 2, 2019

Thanks for the report, I can confirm that this game is missing, and present in the CUE logfile, so scoring didn't read that line for some reason. I'm not yet sure what the best way of fixing this is, but it should be fixable.

rawlins added a commit that referenced this issue Dec 3, 2019
@rawlins
Fix a bug in how logfile offsets are stored in the db
967b94c 
The original implementation had much more apparent behavior:
XLogFile.offset was always the offset of the last read line, and this
was stored in the db. At some point, things got more complicated, and
XLogfile.offset was actually the next read point -- but now this got
stored in the db, and the code to load offsets from the db didn't get
correspondingly changed. Consequently, on daemon restart, if a logfile
had any new loglines, the first one would get dropped. (If it didn't
there were no consequences.) This also caused loglines that were
incomplete on the last wget to be dropped.

In principle, the db could either store the next read point or the last
read line, but I decided the latter was safer. (Unfortunately this
entails one more risky daemon restart on CAO.)

This is the bug that caused #2, just by extremely unlucky timing - the
logline was incomplete by character at the time of the wget.
@rawlins
Copy link
Member

rawlins commented Dec 3, 2019

Alright, I've manually inserted this game into the db and it is showing up on your player page now. It's possible that there may be very minor idiosyncrasies around this game that won't be fixed without a full db rebuild, but everything on your player page looks right to me now.

It failed to be read in the first place because of a bug in the scoring daemon that is now fixed.

@rawlins rawlins closed this as completed Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syranez @rawlins