-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Additional methods #101
base: master
Are you sure you want to change the base?
Additional methods #101
Conversation
Ability to pass the name of the constructor for the controls without the "mapboxgl" prefix (esp. for MapboxGeocoder)
I'm very curious about this direction. Mapbox GL JS 2.0 has some really great new features but is not licensed the same way as Mapbox GL JS 1.0. For example, non-Mercator projections (including globe view!) work out of the box which I think would be of significant interest to R users: library(mapboxer)
mapboxer(
center = c(-73.9165, 40.7114),
zoom = 2,
projection = "globe"
) There's nothing else like that in the R world right now, as far as I know. This requires locking in users to the new Mapbox 2.0 license, however. I wonder if it makes sense to add an option to use Mapbox 2.0 which users could set, then get access to the new features (acknowledging the new license structure)? This would depend on your development philosophy @crazycapivara, so I'd be interested to know what you think. |
The license and the pricing model attached are good points indeed. I actually only need version 1.12 for the methods I'm adding... |
|
Ability to use controls with positional arguments
Added more stuff:
@crazycapivara would you have a moment to have a look at integrating this PR? Thanks!! |
Adding new methods:
Also updating to mapboxgl 2.10.0