Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Wrong HTTP(S)_PROXY value blocks all CRC usage #3098

Closed
jsliacan opened this issue Apr 6, 2022 · 3 comments
Closed

[BUG] Wrong HTTP(S)_PROXY value blocks all CRC usage #3098

jsliacan opened this issue Apr 6, 2022 · 3 comments
Labels
kind/bug Something isn't working os/linux os/macos os/windows priority/minor tags/good first issue Good for newcomers

Comments

@jsliacan
Copy link
Contributor

jsliacan commented Apr 6, 2022

General information

  • OS: Linux

CRC version

CodeReady Containers version: 2.0.1+bf3b1a6
OpenShift version: 4.10.3
Podman version: 3.4.4

CRC status

Machine does not exist. Use 'crc start' to create it

CRC config

- consent-telemetry                     : no
- pull-secret-file                      : /home/jsliacan/Downloads/crc-pull-secret

Steps to reproduce

  1. export HTTP_PROXY=localhost:8080 (for instance)
  2. crc version (or any other command: help, status, start, setup, ...)

Expected

The corresponding output for that command, i.e. for version I'd expect

CodeReady Containers version: 2.0.1+bf3b1a6
OpenShift version: 4.10.3
Podman version: 3.4.4

Actual

FATA[0000] HTTP proxy URL 'localhost:8080' is not valid: url should start with http://

Logs

jsliacan ~ $ crc version
CodeReady Containers version: 2.0.1+bf3b1a6
OpenShift version: 4.10.3
Podman version: 3.4.4
jsliacan ~ $ crc status
Machine does not exist. Use 'crc start' to create it
jsliacan ~ $ crc config view
- consent-telemetry                     : no
- pull-secret-file                      : /home/jsliacan/Downloads/crc-pull-secret
jsliacan ~ $ export HTTP_PROXY=localhost:8080
jsliacan ~ $ crc status
FATA[0000] HTTP proxy URL 'localhost:8080' is not valid: url should start with http:// 
jsliacan ~ $ crc ip
FATA[0000] HTTP proxy URL 'localhost:8080' is not valid: url should start with http:// 
jsliacan ~ $ crc start
FATA[0000] HTTP proxy URL 'localhost:8080' is not valid: url should start with http:// 
jsliacan ~ $ crc 
FATA[0000] HTTP proxy URL 'localhost:8080' is not valid: url should start with http://
@jsliacan jsliacan added kind/bug Something isn't working status/need triage labels Apr 6, 2022
@stale
Copy link

stale bot commented Jun 12, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the status/stale Issue went stale; did not receive attention or no reply from the OP label Jun 12, 2022
@stale stale bot closed this as completed Jul 10, 2022
@jsliacan jsliacan mentioned this issue Jun 1, 2023
Closed
@cfergeau cfergeau reopened this Jun 13, 2023
@jsliacan jsliacan added priority/minor os/linux os/windows os/macos tags/good first issue Good for newcomers and removed status/stale Issue went stale; did not receive attention or no reply from the OP status/need triage labels Jul 26, 2023
@jsliacan
Copy link
Contributor Author

  • might apply to all OSs

anjannath added a commit to anjannath/crc that referenced this issue Sep 1, 2023
@anjannath
proxy: donot use proxy from env variable if it fails validation
bb8eec3 
this adds early validation of http and https proxy values  captured
from env variables, if the values fail validation they are not used
by crc

fixes crc-org#3098
@anjannath anjannath mentioned this issue Sep 1, 2023
Merged
anjannath added a commit to anjannath/crc that referenced this issue Sep 6, 2023
@anjannath
proxy: donot use proxy from env variable if it fails validation
4e0a82c 
this adds early validation of http and https proxy values  captured
from env variables, if the values fail validation they are not used
by crc

fixes crc-org#3098
anjannath added a commit to anjannath/crc that referenced this issue Sep 18, 2023
@anjannath
proxy: donot use proxy from env variable if it fails validation
00bc580 
this adds early validation of http and https proxy values  captured
from env variables, if the values fail validation they are not used
by crc

fixes crc-org#3098
anjannath added a commit to anjannath/crc that referenced this issue Oct 26, 2023
@anjannath
proxy: donot use proxy from env variable if it fails validation
1653a35 
this adds early validation of http and https proxy values  captured
from env variables, if the values fail validation they are not used
by crc

fixes crc-org#3098
anjannath added a commit to anjannath/crc that referenced this issue Nov 1, 2023
@anjannath
warn instead of fatal error when proxy configs are erroneous
d510b26 
when an error is returned from NewProxyConfig because of wrong
proxy env variables or missing proxy ca cert file, in root.go it
was fatal error which prevented running of any crc commands  and
user was not able to unset the invalid config

this changes it to be a warning, which will allow users to correct
the wrong config

this fixes crc-org#3690 crc-org#3098
anjannath added a commit to anjannath/crc that referenced this issue Nov 3, 2023
@anjannath
warn instead of fatal error when proxy configs are erroneous
cffee81 
when an error is returned from NewProxyConfig because of wrong
proxy env variables or missing proxy ca cert file, in root.go it
was fatal error which prevented running of any crc commands  and
user was not able to unset the invalid config

this changes it to be a warning, which will allow users to correct
the wrong config

this fixes crc-org#3690 crc-org#3098
anjannath added a commit to anjannath/crc that referenced this issue Nov 6, 2023
@anjannath
warn instead of fatal error when proxy configs are erroneous
d3b248a 
when an error is returned from NewProxyConfig because of wrong
proxy env variables or missing proxy ca cert file, in root.go it
was fatal error which prevented running of any crc commands  and
user was not able to unset the invalid config

this changes it to be a warning, which will allow users to correct
the wrong config

this fixes crc-org#3690 crc-org#3098
anjannath added a commit to anjannath/crc that referenced this issue Nov 6, 2023
@anjannath
warn instead of fatal error when proxy configs are erroneous
59a253d 
when an error is returned from NewProxyConfig because of wrong
proxy env variables or missing proxy ca cert file, in root.go it
was fatal error which prevented running of any crc commands  and
user was not able to unset the invalid config

this changes it to be a warning, which will allow users to correct
the wrong config

this fixes crc-org#3690 crc-org#3098
praveenkumar pushed a commit that referenced this issue Nov 7, 2023
@anjannath @praveenkumar
warn instead of fatal error when proxy configs are erroneous
da1d72e 
when an error is returned from NewProxyConfig because of wrong
proxy env variables or missing proxy ca cert file, in root.go it
was fatal error which prevented running of any crc commands  and
user was not able to unset the invalid config

this changes it to be a warning, which will allow users to correct
the wrong config

this fixes #3690 #3098
@anjannath
Copy link
Member

was fixed in #3816

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/bug Something isn't working os/linux os/macos os/windows priority/minor tags/good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cfergeau @jsliacan @anjannath