-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] crc config set
regression after commit f9a0a4a83
#3663
Comments
has the value been set (removed from the config/reset to default)? |
Yes, it's only the message which is missing:
|
This should fix crc-org#3663 Before this commit, the steps below $ crc config set preset openshift $ crc config set cpus 4 no longer print: Changes to configuration property 'cpus' are only applied when the CRC instance is started. If you already have a running CRC instance, then for this configuration change to take effect, stop the CRC instance with 'crc stop' and restart it with 'crc start'.
This should fix crc-org#3663 Before this commit, the steps below $ crc config set preset openshift $ crc config set cpus 4 no longer print: Changes to configuration property 'cpus' are only applied when the CRC instance is started. If you already have a running CRC instance, then for this configuration change to take effect, stop the CRC instance with 'crc stop' and restart it with 'crc start'.
This should fix crc-org#3663 Before this commit, the steps below $ crc config set preset openshift $ crc config set cpus 4 no longer print: Changes to configuration property 'cpus' are only applied when the CRC instance is started. If you already have a running CRC instance, then for this configuration change to take effect, stop the CRC instance with 'crc stop' and restart it with 'crc start'.
This should fix crc-org#3663 Before this commit, the steps below $ crc config set preset openshift $ crc config set cpus 4 no longer print: Changes to configuration property 'cpus' are only applied when the CRC instance is started. If you already have a running CRC instance, then for this configuration change to take effect, stop the CRC instance with 'crc stop' and restart it with 'crc start'.
Not sure if this can go under the same issue (new default values behavior).
I'm doing some checks in tests and exitcode 1 is not what I would expect given that I just successfully set a preset. |
This should fix crc-org#3663 Before this commit, the steps below $ crc config set preset openshift $ crc config set cpus 4 no longer print: Changes to configuration property 'cpus' are only applied when the CRC instance is started. If you already have a running CRC instance, then for this configuration change to take effect, stop the CRC instance with 'crc stop' and restart it with 'crc start'.
This should fix crc-org#3663 Before this commit, the steps below $ crc config set preset openshift $ crc config set cpus 4 no longer print: Changes to configuration property 'cpus' are only applied when the CRC instance is started. If you already have a running CRC instance, then for this configuration change to take effect, stop the CRC instance with 'crc stop' and restart it with 'crc start'.
This specific issue is caused by f9a0a4a , but the root cause is what is being discussed here. |
This should fix crc-org#3663 Before this commit, the steps below $ crc config set preset openshift $ crc config set cpus 4 no longer print: Changes to configuration property 'cpus' are only applied when the CRC instance is started. If you already have a running CRC instance, then for this configuration change to take effect, stop the CRC instance with 'crc stop' and restart it with 'crc start'.
(reopened to continue the conversation around exit codes for |
Exit code bug is also fixed, closing it now. |
Before commit f9a0a4a:
After commit f9a0a4a, when setting
cpus
to its default value we no longer get the warning:The text was updated successfully, but these errors were encountered: