Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: separate port 80 and 443 remote haproxy sections #1662

Merged
merged 1 commit into from
Nov 12, 2020

Conversation

ktdreyer
Copy link
Contributor

Relates to: #705

Solution/Idea

Prior to this change, HAproxy would send all remote incoming traffic (both HTTP and HTTPS) to port 443 on the CRC VM. Remote HTTPS connections worked, but remote HTTP connections failed.

Proposed changes

Split the apps configuration into two separate sections: apps and apps_ssl. Each section will handle traffic on TCP 80 or TCP 443.

Testing

  1. Follow the existing instructions for setting up CRC on a remote server
  2. Connect to the instance with HTTP (port 80), note that HAproxy closes the connection prematurely
  3. Reconfigure HAproxy according to this pull request
  4. Connect to the instance with HTTP and HTTPS, note that HAproxy handles both types of connections now

Prior to this change, HAproxy would send all remote incoming traffic
(both HTTP and HTTPS) to port 443 on the CRC VM. Remote HTTPS
connections worked, but remote HTTP connections failed.

Split the "apps" configuration into two separate sections: "apps" and
"apps_ssl". Each section will handle traffic on TCP 80 or TCP 443.
@centos-ci
Copy link
Collaborator

Can one of the admins verify this patch?

@openshift-ci-robot
Copy link

Hi @ktdreyer. Thanks for your PR.

I'm waiting for a code-ready member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ktdreyer, robin-owen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot
Copy link
Contributor

@ktdreyer: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-crc af4124b link /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@gbraad
Copy link
Contributor

gbraad commented Nov 12, 2020

Remote HTTPS connections worked, but remote HTTP connections failed.

Thanks. Would appreciate peer-review.

@kowen-rh
Copy link
Contributor

LGTM. 👍

@kowen-rh kowen-rh merged commit 9d20e9f into crc-org:master Nov 12, 2020
@ktdreyer ktdreyer deleted the external-haproxy-http branch February 5, 2021 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants