-
Notifications
You must be signed in to change notification settings - Fork 239
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: separate port 80 and 443 remote haproxy sections #1662
Conversation
Prior to this change, HAproxy would send all remote incoming traffic (both HTTP and HTTPS) to port 443 on the CRC VM. Remote HTTPS connections worked, but remote HTTP connections failed. Split the "apps" configuration into two separate sections: "apps" and "apps_ssl". Each section will handle traffic on TCP 80 or TCP 443.
Can one of the admins verify this patch? |
Hi @ktdreyer. Thanks for your PR. I'm waiting for a code-ready member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ktdreyer, robin-owen The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@ktdreyer: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Thanks. Would appreciate peer-review. |
LGTM. 👍 |
Relates to: #705
Solution/Idea
Prior to this change, HAproxy would send all remote incoming traffic (both HTTP and HTTPS) to port 443 on the CRC VM. Remote HTTPS connections worked, but remote HTTP connections failed.
Proposed changes
Split the
apps
configuration into two separate sections:apps
andapps_ssl
. Each section will handle traffic on TCP 80 or TCP 443.Testing