Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disk-resize: Don't try to resize disk if there is no free space #3734

Merged
merged 1 commit into from
Jul 3, 2023

Conversation

praveenkumar
Copy link
Member

we did refactor 655822f and because of this now disk resize steps executed even there is no free space in the disk. Before this refactor we used to return early as soon as there is a specfic exit code from growpart command in case no free space on disk.

With this PR we are reverting this functionality to make sure we return early if there is no space on disk to grow.

we did refactor 655822f and because of
this now disk resize steps executed even there is no free space in the
disk. Before this refactor we used to return early as soon as there is a
specfic exit code from `growpart` command in case no free space on disk.

With this PR we are reverting this functionality to make sure we return
early if there is no space on disk to grow.
@openshift-ci openshift-ci bot requested review from anjannath and gbraad June 26, 2023 09:43
@cfergeau cfergeau changed the title disk-resize: remove runGrowPart helper disk-resize: Don't try to resize disk if there is no free space Jun 26, 2023
@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfergeau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jun 26, 2023

@praveenkumar: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc e0f6731 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit 8013005 into crc-org:main Jul 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants