remove all the log files when running crc delete --clear-cache
#3753
Conversation
anjannath
force-pushed
the
logfile-cleaning
branch
from
11a8823
to
91653b7
Compare
|
/lgtm |
|
/hold Till it is tested on windows. |
anjannath
force-pushed
the
logfile-cleaning
branch
from
91653b7
to
c2f0585
Compare
anjannath
force-pushed
the
logfile-cleaning
branch
2 times, most recently
from
04e33f0
to
e576d38
Compare
|
/retest |
1 similar comment
|
/retest |
|
/test integration-crc |
anjannath
force-pushed
the
logfile-cleaning
branch
from
e576d38
to
8b75bac
Compare
anjannath
force-pushed
the
logfile-cleaning
branch
from
8b75bac
to
704ad09
Compare
|
@praveenkumar tested on windows as well now, and the behavior is modified to delete all log files on |
pkg/os/util.go
Outdated
| @@ -113,3 +113,17 @@ func RemoveFileIfExists(path string) error { | |||
| func RunningUsingSSH() bool { | |||
| return os.Getenv("SSH_TTY") != "" | |||
| } | |||
|
|
|||
| // RemoveFileGlob takes a glob pattern as string and removes the files that matches | |||
There was a problem hiding this comment.
the files and directories that matches (because of the use of RemoveAll)
There was a problem hiding this comment.
@cfergeau @praveenkumar after this change we can merge, right?
@anjannath ^^^
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cfergeau The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
currently after crc-org#3720 was merged it is deleting the 'crc.log' and 'crcd.log' files and not deleting the backups this adds deletion of the backed up log files named crc-*.log and removes deletion of the crc.log file which is handled by 'crc cleanup' it removes the deletion of crcd.log file as when delete is performed the daemon still keeps running in the background
this renames the removeOldLogs func to removeAllLogs and uses the 'RemoveFileGlob' func with '*.log' glob which deletes all the log files
this was mistakenly recreated inside the InitLogrus function again
anjannath
force-pushed
the
logfile-cleaning
branch
from
704ad09
to
d61deb2
Compare
|
New changes are detected. LGTM label has been removed. |
|
@anjannath: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
currently after #3720 was merged it is only deleting the
'crc.log' and 'crcd.log' files and not deleting the backups