Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpm: Update admin-helper/machine-driver-libvirt RPMs #4163

Merged
merged 1 commit into from
May 15, 2024

Conversation

cfergeau
Copy link
Contributor

make test-rpmbuild uses a container images with preinstalled
admin-helper/machine-driver-libvirt RPMs to generate a crc binary/rpm
embedding these binaries.
However, the versions used no longer match what crc expects, which
is causing issues.

This was reported in #4144

Fixes: Issue #4144

`make test-rpmbuild` uses a container images with preinstalled
admin-helper/machine-driver-libvirt RPMs to generate a `crc` binary/rpm
embedding these binaries.
However, the versions used no longer match what crc expects, which
is causing issues.

This was reported in crc-org#4144

Signed-off-by: Christophe Fergeau <cfergeau@redhat.com>
Copy link

openshift-ci bot commented May 14, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from cfergeau. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

openshift-ci bot commented May 14, 2024

@cfergeau: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security f27dfbe link false /test security
ci/prow/e2e-crc f27dfbe link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@praveenkumar praveenkumar merged commit f6c4e43 into crc-org:main May 15, 2024
24 of 30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants