Misc fixes #26
Merged
Misc fixes #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praveenkumar
approved these changes
May 17, 2019
| OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE=quay.io/openshift-release-dev/ocp-release:${OPENSHIFT_RELEASE_VERSION} | ||
| export OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE | ||
| echo "Setting OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE to ${OPENSHIFT_INSTALL_RELEASE_IMAGE_OVERRIDE}" | ||
| fi | ||
|
|
||
| # Generate a new ssh keypair for this cluster | ||
| rm id_rsa_crc* || true | ||
| ssh-keygen -N "" -f id_rsa_crc |
createdisk.sh
Outdated
| # Resize the image from the default 1+15GB to 1+20GB | ||
| # This should also take care of making the image sparse | ||
| ${QEMU_IMG} create -f qcow2 $tarballDirectory/${CRC_VM_NAME}.qcow2 21G | ||
| ${VIRT_RESIZE} --expand /dev/sda3 $tarballDirectory/${VM_PREFIX}-base $tarballDirectory/${CRC_VM_NAME}.qcow2 |
|
@cfergeau you need to resolve the conflict here. |
This avoids permanently storing id_rsa_crc/id_rsa_crc.pub in our git repository. Note that this file will end up in our tarballs though. crc-org#18
At the moment, the static hostname of the VM we create is just localhost.localdomain, it infers a crc-xxxxx-master-0 hostname from dhcp. It's better to set a static one to the right value. crc-org#21
The default disk image has a 15GB partition for 'user' data. After running openshift-install, about half of it is used, and kubernetes detects disk pressure when there is less than 20% of free space. This means the user has ~5GB of usable free space before disk pressure is detected. This commit raises the disk image from 15GB to 20GB, which means 10GB of free space. Since qcow2, vmdk and vhdx all use dynamically allocated disk space, this should not have a noticeable impact on the size of the resulting file. This commit removes the call to virt-sparsify as virt-resize man page indicates it should take care of doing this. crc-org#19
If we set OPENSHIFT_RELEASE_VERSION to "", it will return false when tested using -n. This commit changes the tests to != "" instead. crc-org#24
This adds 30 10GB PVs located in the VM under /mnt/pv-data/ Tested by following http://kubernetesbyexample.com/pv/ crc-org#16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each commit fixes one reported issue