bcdice: DiceBot が読み込まれない問題を解消する #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #108 bcdiceメソッドが長くなったため
Ruby 2.2以前はBcdiceで使っている新しい文法（&.）に 対応していないため
|
da72a29 でRuby 2.2以前への対応を落としたのは、現在のコードが既に2.3以降でないと動作しなくなっていたためです。2.3系でさえもうすぐEOLとのことなので、問題ないと思います。 |
koi-chan
reviewed
Jul 27, 2018
|
確認ありがとうございます！それではマージいたします。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #108
.bcdiceでゲームシステム未指定時に既定のDiceBotが読み込まれない問題を修正しました。Generatorとテストを追加し、上記条件で正常に読み込まれることを確認しています。