DiceRoll: テスト「出目に偏りがない」で失敗する確率を減らす #141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes #137 カイ二乗検定の閾値を緩くすることで、意に反してテストが失敗する確率を 大幅に減らした（正しい分布の場合に失敗する確率が10万分の1まで低下）。 閾値は、統計解析ソフトウェアのR v3.6.0で算出した。 閾値が緩くなったが、出目が固定されるといったバグは確実に検出できる。
|
修正ありがとうございます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiceRollのテスト「出目に偏りがない」の閾値を緩くすることで、意に反してテストが失敗する確率を大幅に減らしました。正しい分布の場合に失敗する確率が10万分の1まで低下しました（これまでの失敗確率は2000回に1回でした）。このように変更しても、出目が固定されるといったバグは確実に検出できます。