アダプターの設定を渡すオブジェクトを Hash から Struct に変更 #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2019
Closed
Merged
| :root_path, | ||
| :plugin, | ||
| :logger, | ||
| ) |
There was a problem hiding this comment.
名前を含めてこれで大丈夫です。
メンバが増えてくると初期化が大変なので、将来的には Struct.new で keyword_init: true を指定し、キーワード引数で順番と関係なく初期化できるようにしたいです。ただ、現在はそれに対応していないRuby 2.4も動作環境に含んでいるので、残念ながら変えられませんでした。
参考：
ochaochaocha3
approved these changes
Jul 23, 2019
ochaochaocha3
merged commit 6eeb043
into
arrange-plugin-adapter-module_namespace-and-path
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #132
名前を RGRB::PluginBase::AdapterOptions にしてみたが、RGRB::Config 等と同様の名前空間においた方が良かっただろうか。