Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

設定ファイルを IRC/Discord 用それぞれに分離する #152

Merged
merged 6 commits into from
Jul 24, 2019

Conversation

koi-chan
Copy link
Member

fix #151

設定ファイル rgrb.yaml を IRC 用の設定ファイルとして名前を変更し、Discord 関係の内容を削除した。

@koi-chan koi-chan self-assigned this Jul 24, 2019
Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

さっそくありがとうございます。

READMEの文章をより分かりやすくできそうでしたので、案を見ていただければ幸いです。

あと、IRCボットおよびDiscordボットのデフォルト設定IDも変えた方がいいかもしれないと思いました。それぞれ以下の部分を ircdiscord に変更すると、起動時の -c オプションを省略できて楽そうです:

default_options = {
config_id: 'rgrb',
log_level: :warn
}

default_options = {
config_id: 'rgrb'
}

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@koi-chan
Copy link
Member Author

確認ありがとうございます。
修正しました。

Copy link
Member

@ochaochaocha3 ochaochaocha3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKです!

@ochaochaocha3 ochaochaocha3 merged commit 69c79df into master Jul 24, 2019
@koi-chan koi-chan deleted the separate-each-bot-config-file branch July 24, 2019 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

config/rgrb.yaml: Discordの設定のキーの誤り
2 participants