Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spec ファイルの名前を変更 #163

Merged
merged 1 commit into from
Jul 30, 2019
Merged

spec ファイルの名前を変更 #163

merged 1 commit into from
Jul 30, 2019

Conversation

koi-chan
Copy link
Member

configurable というよりも plugin_base/* を対象とするテストスクリプトになった

@koi-chan
spec ファイルの名前を変更
e7f5ac1 
configurable というよりも plugin_base/* を対象とするテストスクリプトになった
@koi-chan koi-chan added this to the v1.1.0 milestone Jul 30, 2019
@ochaochaocha3
Copy link
Member

ありがとうございます。ご指摘のとおりですね！

@ochaochaocha3 ochaochaocha3 merged commit 7c4e22b into arrange-plugin-adapter-module Jul 30, 2019
@koi-chan koi-chan deleted the arrange-plugin-adapter-module_rename-spec branch July 30, 2019 08:47
@ochaochaocha3
Copy link
Member

ochaochaocha3 commented Jul 30, 2019 •
edited
Loading

@koi-chan マージした後で気づいたのですが、ファイル名が *_spec.rb でなくなったため、自動でテストが実行されなくなっていました（確認不足ですみません）。plugin_base_spec.rb に変えておきましょうか？

@ochaochaocha3 ochaochaocha3 mentioned this pull request Jul 30, 2019
Closed
@koi-chan koi-chan restored the arrange-plugin-adapter-module_rename-spec branch August 1, 2019 17:28
@koi-chan
Copy link
Member Author

koi-chan commented Aug 1, 2019

fix #165

修正しました。
再度確認・マージをお願いします。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@koi-chan @ochaochaocha3