BCDice ライブラリを v2 から v3 に更新 #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ついでに現段階で使用していない機能のリファクタリング
|
テストを修正しました。 現在は RC 版の BCDice を使っているため、バージョン番号のテストが失敗しています。 |
|
バージョン番号のテストの条件はもっと緩くしてもよさそうですね。v2とは違ってsemverになったので、大雑把に |
ochaochaocha3
approved these changes
Jan 7, 2021
緩くし、テストが通るようにしました。 |
ochaochaocha3
approved these changes
Jan 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gem になった BCDice ライブラリを使うようにしました。
現段階ではまだテストバージョンですが、問題なく動作していると思います。