Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for FORMULA cells when typing to String or Numeric types #31

Closed
wants to merge 2 commits into from

Conversation

habelson
Copy link
Contributor

Pull Request to support issue #30 . This patch will work in most cases where cached values exist in the saved worksheet. I was not able to add support for typing other than String or Numeric, perhaps someone else can embellish.

@nightscape
Copy link
Owner

Out of interest: Could you also evaluate the cells if no cached value exists?

@habelson
Copy link
Contributor Author

habelson commented Oct 23, 2017

@nightscape I can look into it, but in my case the formulas are external references, so we would need some sort of graceful fallback if a formula could not be evaluated

@nightscape
Copy link
Owner

Yeah, that would probably be the best option.
Would you mind adding that?
If not, I'm also OK with merging it as is.

@litzebauer
Copy link

@nightscape Any chance you can merge this change in?

@nightscape
Copy link
Owner

I just rebased this PR and released it as 0.9.9. It will probably take a few hours until it is available via Sonatype.
Could you give it a whirl and report back here in case there are problems?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants