Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improves the user interface for resource cards and makes them responsive #298

Merged
merged 35 commits into from
Jul 2, 2024

Conversation

Murdock9803
Copy link
Member

@Murdock9803 Murdock9803 commented Jul 1, 2024

Fixes

Description

The pull request works mainly on the section where all the resource cards are being displayed. This focuses on improving the design and style of the cards based on the vocabulary directory. The pull request also focuses on the responsiveness of the resource grid.

Technical details

The Pull request performs the following actions:

  • Refactored the structure of resource card to IMAGE - TITLE - BLURB in listing.html
  • Utilising vocabulary, enhanced the style for #thumbnaillist in listing.html. Worked on the grid structure in style.css.
  • Likewise, worked on enhancing style for .thumbnailbox, .thumbnailtitle, .thumbnail and thumbnailblurb.
  • Worked on Fonts, colors, background colors, etc. according to vocabulary.
  • Assigned properties like --underline-background-color from vocabulary into style.css
  • Formatted the style.css and listing.html files with prettier
  • Fixed the responsiveness of the resource cards.
  • Added Documentation in style.css for understandability.

Screenshots

Some screenshots after the work has been done:
image

For medium sized screens (the columns become 3 in number):
image

For small sized screens (the columns become 2 in number):
image

For mobile screens (single column):
image

Additional Context

The inspiration for the design of resource cards has been drawn from the vocabulary blog-index page

Checklist

  • My pull request has a descriptive title (not a vague title like Update index.md).
  • My pull request targets the default branch of the repository (main or master).
  • My commit messages follow best practices.
  • My code follows the established code style of the repository.
  • I added or updated tests for the changes I made (if applicable).
  • I added or updated documentation (if applicable).
  • I tried running the project locally and verified that there are no
    visible errors.

Developer Certificate of Origin

For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."

Developer Certificate of Origin
Developer Certificate of Origin
Version 1.1

Copyright (C) 2004, 2006 The Linux Foundation and its contributors.
1 Letterman Drive
Suite D4700
San Francisco, CA, 94129

Everyone is permitted to copy and distribute verbatim copies of this
license document, but changing it is not allowed.


Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
    have the right to submit it under the open source license
    indicated in the file; or

(b) The contribution is based upon previous work that, to the best
    of my knowledge, is covered under an appropriate open source
    license and I have the right under that license to submit that
    work with modifications, whether created in whole or in part
    by me, under the same open source license (unless I am
    permitted to submit under a different license), as indicated
    in the file; or

(c) The contribution was provided directly to me by some other
    person who certified (a), (b) or (c) and I have not modified
    it.

(d) I understand and agree that this project and the contribution
    are public and that a record of the contribution (including all
    personal information I submit with it, including my sign-off) is
    maintained indefinitely and may be redistributed consistent with
    this project or the open source license(s) involved.

@Murdock9803 Murdock9803 requested a review from a team as a code owner July 1, 2024 14:34
@Murdock9803 Murdock9803 requested review from TimidRobot and removed request for a team July 1, 2024 14:34
@Murdock9803 Murdock9803 requested review from annatuma and possumbilities and removed request for TimidRobot and annatuma July 1, 2024 14:34
@Murdock9803
Copy link
Member Author

@possumbilities Please have a look at this PR. I'll try keeping the future PRs shorter than this one.

@possumbilities
Copy link
Contributor

The thumbnails and thumbnail listings likely need to be more semantic elements than the use of div. See the https://creativecommons.org homepage. There's an argument for the use of article for both, but its possible the use of ul and article and even div could have merit.

@possumbilities
Copy link
Contributor

@Murdock9803 This is looking great! I left a few comments above for some changes that should be included, but overall its a good direction!

@Murdock9803
Copy link
Member Author

The thumbnails and thumbnail listings likely need to be more semantic elements than the use of div. See the https://creativecommons.org homepage. There's an argument for the use of article for both, but its possible the use of ul and article and even div could have merit.

@possumbilities I have replaced the div elements with artcile, just as it is done in vocabulary blog-index page
Should we go with the ul>li approach ? as the direct children of a <ul> element should preferably be <li>

@possumbilities
Copy link
Contributor

@Murdock9803 as its a listing of items, I think it does make semantic sense to have it be ul > li > article

@Murdock9803
Copy link
Member Author

@possumbilities I have restructured the thumbnaillist as ul>li>article and checked for the functionality of filtering resources. everything works fine.

@Murdock9803
Copy link
Member Author

@possumbilities, please suggest any more changes needed, if there are some

Copy link
Contributor

@possumbilities possumbilities left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

@possumbilities possumbilities merged commit f25f12e into main Jul 2, 2024
@possumbilities possumbilities deleted the listing-card branch July 2, 2024 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants