-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improves the user interface for resource cards and makes them responsive #298
Conversation
…inline styling in listing.html
@possumbilities Please have a look at this PR. I'll try keeping the future PRs shorter than this one. |
The thumbnails and thumbnail listings likely need to be more semantic elements than the use of |
@Murdock9803 This is looking great! I left a few comments above for some changes that should be included, but overall its a good direction! |
@possumbilities I have replaced the |
@Murdock9803 as its a listing of items, I think it does make semantic sense to have it be |
@possumbilities I have restructured the thumbnaillist as |
@possumbilities, please suggest any more changes needed, if there are some |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
Fixes
Description
The pull request works mainly on the section where all the
resource cards
are being displayed. This focuses on improving the design and style of the cards based on thevocabulary
directory. The pull request also focuses on the responsiveness of theresource grid
.Technical details
The Pull request performs the following actions:
listing.html
#thumbnaillist
inlisting.html
. Worked on thegrid structure
instyle.css
..thumbnailbox
,.thumbnailtitle
,.thumbnail
andthumbnailblurb
.--underline-background-color
from vocabulary into style.cssstyle.css
andlisting.html
files withprettier
Screenshots
Some screenshots after the work has been done:
For medium sized screens (the columns become 3 in number):
For small sized screens (the columns become 2 in number):
For mobile screens (single column):
Additional Context
The inspiration for the design of resource cards has been drawn from the vocabulary blog-index page
Checklist
Update index.md
).main
ormaster
).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin