Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Short name misses version number #189

Closed
fkohrt opened this issue Oct 17, 2020 · 0 comments · Fixed by #190
Closed

Short name misses version number #189

fkohrt opened this issue Oct 17, 2020 · 0 comments · Fixed by #190
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work

Comments

@fkohrt
Copy link
Contributor

fkohrt commented Oct 17, 2020 •
edited

Description

A license's short name should also contain the version number, right? This is missing here:

chooser/src/components/HelpSection.vue

Lines 195 to 196 in e0d79d6

<th>{{ $t('help.how-licenses-communicated.short-name') }}</th>
<td>CC BY-NC</td>

Expectation

CC BY-NC 4.0
@fkohrt fkohrt added 💻 aspect: code Concerns the software code in the repository 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents labels Oct 17, 2020
@fkohrt fkohrt mentioned this issue Oct 17, 2020
Merged
7 tasks
obulat pushed a commit that referenced this issue Oct 19, 2020
@fkohrt
Add license version number to the short license name. Closes #189 (#190)
8056d3f 
Short name misses version number
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
💻 aspect: code Concerns the software code in the repository 🛠 goal: fix Bug fix 🟧 priority: high Stalls work on the project or its dependents 🚦 status: awaiting triage Has not been triaged & therefore, not ready for work
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #189
1 participant
@fkohrt