fix #41:

a message  was sent to stderr when parameter initialize=true and repo exists

Author: creativeprojects

examples/dev.yaml

@@ -80,7 +80,7 @@ self:
     inherit: default
     status-file: /Volumes/RAMDisk/status.json
     backup:
-        extended-status: true
+        extended-status: false
         check-before: false
         no-error-on-warning: true
         source: {{ .CurrentDir }}

shell/command.go

@@ -84,9 +84,11 @@ func (c *Command) Run() (Summary, string, error) {
 	} else {
 		cmd.Stdout = c.Stdout
 	}
-	stderr, err = cmd.StderrPipe()
-	if err != nil {
-		cmd.Stderr = c.Stderr
+	if c.Stderr != nil {
+		stderr, err = cmd.StderrPipe()
+		if err != nil {
+			cmd.Stderr = c.Stderr
+		}
 	}
 	cmd.Stdin = c.Stdin
 

shell/command_test.go

@@ -279,11 +279,12 @@ func TestStderr(t *testing.T) {
 	}
 
 	cmd := NewCommand("echo", []string{"error message", ">&2"})
-	buffer := &bytes.Buffer{}
-	cmd.Stdout = buffer
+	bufferStdout, bufferStderr := &bytes.Buffer{}, &bytes.Buffer{}
+	cmd.Stdout = bufferStdout
+	cmd.Stderr = bufferStderr
 	_, stderr, err := cmd.Run()
 	require.NoError(t, err)
-	assert.Empty(t, buffer.String())
+	assert.Empty(t, bufferStdout.String())
 	assert.Equal(t, expected, stderr)
 }
 
@@ -295,14 +296,38 @@ func TestStderrSignalledCommand(t *testing.T) {
 
 	sigChan := make(chan os.Signal, 1)
 	cmd := NewSignalledCommand("echo", []string{"error message", ">&2"}, sigChan)
-	buffer := &bytes.Buffer{}
-	cmd.Stdout = buffer
+	bufferStdout, bufferStderr := &bytes.Buffer{}, &bytes.Buffer{}
+	cmd.Stdout = bufferStdout
+	cmd.Stderr = bufferStderr
 	_, stderr, err := cmd.Run()
 	require.NoError(t, err)
-	assert.Empty(t, buffer.String())
+	assert.Empty(t, bufferStdout.String())
 	assert.Equal(t, expected, stderr)
 }
 
+func TestStderrNotRedirected(t *testing.T) {
+	cmd := NewCommand("echo", []string{"error message", ">&2"})
+	bufferStdout := &bytes.Buffer{}
+	cmd.Stdout = bufferStdout
+	cmd.Stderr = nil
+	_, stderr, err := cmd.Run()
+	require.NoError(t, err)
+	assert.Empty(t, bufferStdout.String())
+	assert.Equal(t, "", stderr)
+}
+
+func TestStderrNotRedirectedSignalledCommand(t *testing.T) {
+	sigChan := make(chan os.Signal, 1)
+	cmd := NewSignalledCommand("echo", []string{"error message", ">&2"}, sigChan)
+	bufferStdout := &bytes.Buffer{}
+	cmd.Stdout = bufferStdout
+	cmd.Stderr = nil
+	_, stderr, err := cmd.Run()
+	require.NoError(t, err)
+	assert.Empty(t, bufferStdout.String())
+	assert.Equal(t, "", stderr)
+}
+
 // Try to make a test to make sure restic is catching the signal properly
 func TestResticCanCatchInterruptSignal(t *testing.T) {
 	// if runtime.GOOS == "windows" {